Skip to content

Add function to search for available crates within a directory#4

Merged
Blast545 merged 7 commits into
mainfrom
blast545/add_get_available_crates
Feb 23, 2026
Merged

Add function to search for available crates within a directory#4
Blast545 merged 7 commits into
mainfrom
blast545/add_get_available_crates

Conversation

@Blast545

@Blast545 Blast545 commented Feb 10, 2026

Copy link
Copy Markdown
Collaborator

As the title says, split part from #1

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 requested a review from cottsay February 10, 2026 18:20
@Blast545 Blast545 self-assigned this Feb 10, 2026
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 force-pushed the blast545/add_get_available_crates branch 5 times, most recently from f11d968 to eaf2389 Compare February 11, 2026 04:40
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@cottsay

cottsay commented Feb 13, 2026

Copy link
Copy Markdown
Member

So for clarity, will this eventually replace this section of compose?

https://github.com/cottsay/pallet-patcher/blob/9f9fbcd4a5e6c801c1e1b24668d868ca2cfee202/pallet_patcher/search.py#L54-L62

@Blast545

Copy link
Copy Markdown
Collaborator Author

@cottsay Yes! They point of those functions is being capable of searching the crates before iterating on the dependencies. I think it makes the code easier to troubleshoot.

@Blast545

Copy link
Copy Markdown
Collaborator Author

Comment thread pallet_patcher/search.py Outdated
Comment thread pallet_patcher/search.py
Comment thread pallet_patcher/search.py
Blast545 and others added 3 commits February 20, 2026 13:13
Co-authored-by: Scott K Logan <logans@cottsay.net>
Co-authored-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Comment thread test/packages/upper_layer/pkg-e-0.0.0/Cargo.toml Outdated

@cottsay cottsay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment left.

Co-authored-by: Scott K Logan <logans@cottsay.net>
@Blast545 Blast545 merged commit fba02ac into main Feb 23, 2026
23 checks passed
@cottsay cottsay deleted the blast545/add_get_available_crates branch February 24, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants