Skip to content

Drop distutils as it is deprecated - #194

Merged
cottsay merged 7 commits into
ros-infrastructure:masterfrom
MatthijsBurgh:patch-1
May 22, 2026
Merged

Drop distutils as it is deprecated#194
cottsay merged 7 commits into
ros-infrastructure:masterfrom
MatthijsBurgh:patch-1

Conversation

@MatthijsBurgh

Copy link
Copy Markdown
Contributor

No description provided.

@MatthijsBurgh

Copy link
Copy Markdown
Contributor Author

@tfoote @cottsay @mikepurvis please review this PR.

@tfoote tfoote left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay reviewing. Thanks for contributing this. It's luckily a small tweak.

Can you rebase to a more recent commit to get the CI runs to trigger? Otherwise this looks great to add.

@MatthijsBurgh

MatthijsBurgh commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

@tfoote rebase done

I need approval for a workflow run

@codecov-commenter

codecov-commenter commented Oct 17, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@02d3707). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/rosdistro/vcs.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #194   +/-   ##
=========================================
  Coverage          ?   39.85%           
=========================================
  Files             ?       51           
  Lines             ?     3264           
  Branches          ?      661           
=========================================
  Hits              ?     1301           
  Misses            ?     1786           
  Partials          ?      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthijsBurgh

Copy link
Copy Markdown
Contributor Author

The version of the git client on windows is 2.51.0.windows.2. It is not accepted by packaging. We either have to do pre-processing. Or keep using the distutils module shipped by setuptools. @cottsay what do you think?

@MatthijsBurgh

Copy link
Copy Markdown
Contributor Author

@cottsay please respond to my previous comment

@cottsay

cottsay commented Nov 21, 2025

Copy link
Copy Markdown
Member

I don't have any silver bullets here. We clearly need to get away from distutils, so I'd guess we'll have to do some intermediate processing, which is a bummer. I'm open to suggestions.

@MatthijsBurgh

Copy link
Copy Markdown
Contributor Author

@cottsay @tfoote please approve workflow run

@MatthijsBurgh

MatthijsBurgh commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

I have no clue why the CI fails. As it runs on my account, https://github.com/MatthijsBurgh/rosdistro-1/actions/runs/21364087466

I had to restart it a few times. It looks more like a bug in GH actions than a failing pipeline.

@cottsay

cottsay commented Jan 26, 2026

Copy link
Copy Markdown
Member

I had to restart it a few times. It looks more like a bug in GH actions than a failing pipeline.

Agreed. Looks like they're finally acknowledging that there's an issue: https://www.githubstatus.com/incidents/90hj03y5tj3c

@cottsay

cottsay commented Jan 26, 2026

Copy link
Copy Markdown
Member

This will need an update to setup.py and stdeb.cfg to include the new dependency.

@MatthijsBurgh

Copy link
Copy Markdown
Contributor Author

This will need an update to setup.py and stdeb.cfg to include the new dependency.

@cottsay Done

@MatthijsBurgh

Copy link
Copy Markdown
Contributor Author

@cottsay please approve workflow run and review

Comment thread setup.py Outdated
@MatthijsBurgh

Copy link
Copy Markdown
Contributor Author

@cottsay done, please review

@MatthijsBurgh

Copy link
Copy Markdown
Contributor Author

@cottsay friendly ping

@tfoote tfoote left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I think that this is good to go now.

@tfoote

tfoote commented May 22, 2026

Copy link
Copy Markdown
Member

@cottsay I'd like your second opinion though.

@tfoote
tfoote requested a review from cottsay May 22, 2026 02:29
@cottsay
cottsay merged commit f494eb3 into ros-infrastructure:master May 22, 2026
@christianrauch christianrauch mentioned this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants