Expand mocking of python variables to fix 1) -pip ending, 2) replace "-" with "_"#206
Merged
Merged
Conversation
…'-' with '_' Signed-off-by: R Kent James <kent@caspia.com> Generated-by: Portions of this commit may include code completion from github.copilot version 1.372.0 or later
tfoote
approved these changes
Nov 12, 2025
tfoote
left a comment
tfoote
left a comment
Member
There was a problem hiding this comment.
We're already guessing so adding these heuristics doesn't seem bad to improve coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200
Generated-by: Portions of this commit may include code completion from github.copilot version 1.372.0 or later
Python modules need to be mocked if they are imported into python files. Although not ideal, rosdoc2 tries to automate this process by parsing the rosdep key and trying to guess the python module. This PR adds two additional categories to the guess: remove any '-pip' at the end, and replace hyphens with underscores.
There are additional, unfixed reasons why the automatic mocking might fail, but this is still a net improvement.