Skip to content

Stop destroying table with change of distro #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

rkent
Copy link

@rkent rkent commented Mar 7, 2025

I didn't like the way that the table flashes away briefly when changing distros. This solves that.

There was an issue that destroying and rebuilding the table solved, and that was to fix the distro fragment reference on the repo column (and group header). But I found another way to solve that, using the global gDistro. You can check that the links in the repo column point to the correct distro.

I also found the Tabulator blockRedraw function, which is used here to stop multiple table redraws when we are changing multiple things.

I have not been able to duplicate the previous issue I had seen with an occasional blank table after a search. Maybe it's gone? In any case, if it is rare, I think that getting rid of the table flash on distro change is worth the occasional glitch, if it still occurs.

@rkent rkent marked this pull request as draft March 27, 2025 17:17
@rkent
Copy link
Author

rkent commented Mar 27, 2025

I changed this to a draft, because I want to think it over.

The issue is that it works TOO well. That is, you change repos, and there is sometimes no visible change to the displayed table. So you cannot tell the difference between a failed or slow repo update, and usable results.

@tfoote
Copy link
Member

tfoote commented Apr 5, 2025

Yeah, if the versions are close enough there wont' be much difference in the results. I guess the optimal for that would be to have an indicator of the distro filtered inside the table that gets rendered. There's a few options:

  • Add a row with the distro -- This is clearly the simplest but it's not much information for a lot of pixels.
  • Make each distro tab a different color and change the header background color similarly. aka Rolling Green, Humble Light Blue, Jazzy Dark blue, .... -- THis would be something to consider across the site as theming, but that's a big refactor and needs to be careful of making the site too noisy.

Reflecting on those first impressions I think that a better one might be to have the full search parameters rendered on the top line in the table.
Distro: rolling Query: rcl*c
This is actually valuable as this information is only currently encoded in the url right now once you start typing a new search query. It could also go with "Showing XX of YYY packages" and as long as we make sure it doesn't update until the table completes or will fail at the same time that should be adaquate to demonstrate that there was a rerender that happened. It could be "Showing XX of YYY packages in rolling matching: 'rcl*c'"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants