Skip to content

added native sensor_msgs::PointCloud2 support without conversion#9

Open
spuetz wants to merge 2 commits intoros-perception:hydro-develfrom
spuetz:hydro-devel
Open

added native sensor_msgs::PointCloud2 support without conversion#9
spuetz wants to merge 2 commits intoros-perception:hydro-develfrom
spuetz:hydro-devel

Conversation

@spuetz
Copy link

@spuetz spuetz commented Jul 19, 2015

Since the conversion from PointCloud2 to PointCloud and back for assembling the clouds is bad, I added a native sensor_msgs::PointCloud2 support without conversion. I also added an organized mode, to assemble PointClouds2 to an organized PointCloud2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrabaud
Copy link
Contributor

vrabaud commented Jul 19, 2015

overall very useful, thank you. It will probably take use a few days to get through the code. I believe some code should be part of the base class (as private lightweight functions). E.g., all that code is duplicated for PointCloud and PointCloud2:

if (field->offset != this->scan_hist_[start_index].fields[chan_ind].offset){

Please have only one function for those (like a function that return analyses two different PointFields)

@vrabaud
Copy link
Contributor

vrabaud commented Aug 2, 2015

@spuetz , any comments on that ?

@spuetz
Copy link
Author

spuetz commented Aug 24, 2015

@vrabaud, I added the method hasEqualScanHeader to check the headers. as recommended by you. Additionally, I fixed the down-sampling for the organized mode.

@spuetz
Copy link
Author

spuetz commented Sep 24, 2015

@vrabaud, would be nice, if we can complete this pull request and merge it. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants