Skip to content

Backport #192 to rolling (backport #246) #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 15, 2025
Merged

Backport #192 to rolling (backport #246) #247

merged 12 commits into from
Sep 15, 2025

Conversation

@mergify
Copy link

@mergify mergify bot commented Sep 15, 2025

This is an automatic backport of pull request #246 done by [Mergify](https://mergify.com).

agoeckner and others added 12 commits September 15, 2025 13:00
@agoeckner @mergify
Added LaserScanBinningFilter.
122a7ca 
(cherry picked from commit 68f302a)
@agoeckner @mergify
Do not override min/max scan angles. Correctly use the angle variab…
8300256 
…le, which is modulo 2*pi.

(cherry picked from commit 1b067b2)
@agoeckner @mergify
In binning filter, do not override the original scan arc. Add warning…
ba960b7 
… for 360-degree LIDAR.

(cherry picked from commit 519a30f)
@agoeckner @mergify
Remove commented code.
13d3f5c 
(cherry picked from commit 0df15c5)
@agoeckner @mergify
Revert "In binning filter, do not override the original scan arc. Add…
c549481 
… warning for 360-degree LIDAR."

This reverts commit 1cb8ae7.

Conflicts:
	include/laser_filters/binning_filter.h

(cherry picked from commit cb21001)
@agoeckner @mergify
Revert "Do not override min/max scan angles. Correctly use the `angle…
ad97046 
…` variable, which is modulo 2*pi."

This reverts commit 88504c4.

(cherry picked from commit a1d3c5c)
@agoeckner @mergify
Use angle variable.
afc9ce0 
(cherry picked from commit b10e544)
@agoeckner @mergify
The filtered scan is now updated to begin at the oldest non-overwritt…
930a91e 
…en data (in case of >360-degree scans). This should also resolve any time_increment edge cases.

(cherry picked from commit 50b304a)
@agoeckner @mergify
Fixed input angle conversion to filtered angle.
6471f9a 
(cherry picked from commit f4b817c)
@agoeckner @mergify
Update copyright email.
4133020 
(cherry picked from commit da47998)
@gftabor @mergify
add example for bin filter
985b95a 
(cherry picked from commit 6816fe3)
@gftabor @mergify
fix time increment math
a54aaf2 
(cherry picked from commit 38a09b0)
@mergify mergify bot mentioned this pull request Sep 15, 2025
Merged
@jonbinney jonbinney merged commit 8f6d345 into kilted Sep 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonbinney @agoeckner @gftabor