-
Notifications
You must be signed in to change notification settings - Fork 359
Humble Porting #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: humble
Are you sure you want to change the base?
Humble Porting #507
Conversation
* Migrate pcl_ros pcd_to_pointcloud tool Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Remove log used for debugging Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Undo unnecessary changes Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Remove commented out code Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Address peer review comments Signed-off-by: Ivan Santiago Paunovic <[email protected]> * rename node Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: wep21 <[email protected]>
…ption#374) * Remove name of nonexistent PCL component (core) Probably, common is meant, which is also requested * Add boost include, missing in upcoming PCL versions Was removed in pcl/conversion.h here: PointCloudLibrary/pcl@292593a
* migrate pcl_nodelet.hpp to pcl_node.hpp TODOs - lazy subscription - cpplint, uncrustify - type adaptation Signed-off-by: Daisuke Sato <[email protected]> * rename latched_indices to transient_local_indices Signed-off-by: Daisuke Sato <[email protected]> * - remove some TODOs - change pub_output_ type Signed-off-by: Daisuke Sato <[email protected]> * remove TODOs Signed-off-by: Daisuke Sato <[email protected]> * use template instead of PublisherBase Signed-off-by: Daisuke Sato <[email protected]> Signed-off-by: Daisuke Sato <[email protected]>
* migrate abstract filter node Signed-off-by: Daisuke Sato <[email protected]> * remove use_frame_params from constructor and make a function for the logic Signed-off-by: Daisuke Sato <[email protected]> Signed-off-by: Daisuke Sato <[email protected]>
* - migrate extract_indices filter - add test to check if filter node/component output result Signed-off-by: Daisuke Sato <[email protected]> * add test_depend to package.xml Signed-off-by: Daisuke Sato <[email protected]> * add launch_testing_ros as test_depend too Signed-off-by: Daisuke Sato <[email protected]> * fixed test not to depend on ros2cli Signed-off-by: Daisuke Sato <[email protected]> --------- Signed-off-by: Daisuke Sato <[email protected]>
* migrate passthrough and project_inliers filters Signed-off-by: Daisuke Sato <[email protected]> * - remove throwing runtime_error (result always true) - use get_subscription_count() Signed-off-by: Daisuke Sato <[email protected]> * change comparison operator Signed-off-by: Daisuke Sato <[email protected]> --------- Signed-off-by: Daisuke Sato <[email protected]>
…rception#399) * Add the RadiusOutlierRemoval filter. * Lint * PLay iit again, Linty Sam. * Header order * This is now just getting embarrassing * Move parameter to class constructor.
* Add squashed commit for CropBox filter * Lint
…s-perception#398) * Add the VoxelGrid filter (squash commit) * Revert the change that brings in separate leaf sizes
…s-perception#406) * Lint! * Fix flake8 errors * Fix clang-tidy errors * Remove [[maybe_unused]]
* Set sensor data QoS to filter subscribers * Fix format for consistency * Fix type * Fix style format
* porting pointcoud_to_pcd to ros2 * and rgb option and swich format * fix exception handling
Signed-off-by: Yadunund <[email protected]>
…on#452) * Fix `Could NOT find Boost (missing: Boost_INCLUDE_DIR)` Fix ros-perception#446 See the discussion at ros-perception#447 * Fix ament_cpplint * Fix ament_lint_cmake
…n#452 (ros-perception#454) Same fix as ros-perception#452, but now for `pcl_conversions` Fix ros-perception#446 See the discussion at ros-perception#447
Signed-off-by: CursedRock17 <[email protected]>
* Add lazy feature * Call createPublishers() from derived class * Check subscriber
Co-authored-by: Paul Bovbel <[email protected]>
…ds into a Single PCD (ros-perception#479) - Introduces CombinedPointCloudToPCD, a ROS 2 component node that: - Subscribes to sensor_msgs/PointCloud2 and accumulates multiple clouds. - Optionally transforms each cloud to a fixed frame. - Allows saving a combined PCD file in either binary, compressed, or ASCII format. - Permits saving on node shutdown or at a configurable timer interval. - Preserves the BSD License from Willow Garage and references original authors. - Useful for aggregating data from multiple scans into one dataset.
…on#494) `bag_to_pcd_lib` was linked publicly to `rosbag2_transport`, which caused downstream packages to also try linking against it. However, `rosbag2_transport` is an internal dependency, and we don't want to expose it to downstream packages. Since `bag_to_pcd_lib` is a tool with no public headers, it doesn't need to expose this dependency. Switching to private linking resolves the issue and keeps the dependency internal.
…tion#497) This warning is resuling in an error on rolling dev.
`ament_target_dependencies` is deprecated rolling, so we should convert all usages to `target_link_libraries`. See also the following discussion: ament/ament_cmake#572
|
A note on my last commit: I can try to make it work on different ROS distros so that it can be cherry-picked in the master. I can use the same approach used in the laser_filters package. This way, future syncs should be easier |
|
Thank you for putting the effort to cherry-pick all relevant commits to humble I have questions about two specific commits:
In general I'm a bit worries the changes will lead to downstream compilation failures. Can @SteveMacenski maybe give his opinion about this PR? Btw, I'm going on vacation for 3 weeks so it might take a while before I come back to this. |
|
My original idea was to minimize the differences between the |
|
I wouldn't change the exported targets / variables in an already released distribution. Rclcpp I see still uses the old ament macro for this in Humble https://github.com/ros2/rclcpp/blob/humble/rclcpp/CMakeLists.txt#L193-L207 so that makes me further think we shouldn't backport that to humble as a ABI breaking change. P.S. I don't particularly recommend the |
Replaces #505 and #501 by properly cherry-picking
ros2commits intohumble.Addresses: #423
Additionally, to fix the build on Humble, small fixes were required:
.get_rmw_qos_profile()in subscriberspub_options.event_callbacks.matched_callback = [this](rclcpp::MatchedInfo & /*info*/) ...is not available in Humble