fix high cpu usage (#9) #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix default parameters in README Some default parameters in the README file are wrong after looking at the source code https://github.com/ros-perception/pointcloud_to_laserscan/blob/rolling/src/pointcloud_to_laserscan_node.cpp#L58 Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit be047d2) Co-authored-by: Carlos Andrés Álvarez Restrepo <[email protected]>
|
Any update on this? Is it worth applying this change to a local fork if using this library still? If it is still the case perhaps someone should open an issue on the tf2 repo about that? |
Collaborator
|
Galactic is EOL and Foxy is close to be. Re-targeting to |
Collaborator
|
@leocornelius thank for the bump. I'd be onboard with merging this and even submitting an issue upstream if there was some raw evidence to back this high cpu usage observation. Neither this PR nor #9 have shown any. An MRE would be ideal, but I'm OK even with some basic profiling results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf2::doTransform is slow and high cpu usage,
so change it to pcl_ros::transformPointCloud.