Fix type checks and typos#60
Conversation
Flova
left a comment
Flova
left a comment
There was a problem hiding this comment.
Also is there any easy way of running the type checks in the CI?
| from rclpy.executors import MultiThreadedExecutor | ||
| from rclpy.node import Node | ||
| from sensor_msgs.msg import CameraInfo, Image, PointCloud2, PointField | ||
| from sensor_msgs.msg import CameraInfo |
There was a problem hiding this comment.
What style did you use? Because I am pretty sure it is okay to group imports in the ros2 one as long as they are in the correct order.
There was a problem hiding this comment.
This was isort with --profile google as you suggested.
I dont know whats right, but I like this more than the brackets () method😅
There was a problem hiding this comment.
I really hate it... it is so verbose ...
There was a problem hiding this comment.
It is at least possible in the example: https://github.com/PyCQA/flake8-import-order/blob/master/tests/test_cases/complete_google.py
There was a problem hiding this comment.
| from geometry_msgs.msg import Transform | ||
| import numpy as np | ||
| from rclpy.duration import Duration | ||
| from rclpy.time import Time |
There was a problem hiding this comment.
What type check did you use? Was it static or during runtime? Because I am quite sure the time used here is the time message. And the rclpy time has a time source etc. and this is not compatible.
There was a problem hiding this comment.
Static.
The types from TF said its this one
There was a problem hiding this comment.
But here we put it into a message and the message has this type.
Dont know yet, but we could commit workspace settings for IDEs, that turn on Type checking. As Bitbots, we will discuss this on wednesday |
|
Ping @jaagut |
3 participants
This PR fixes several type checker errors and typos in
ipm_image_nodeipm_library