Add cross-platform CI with conda packages (minimal version)#1636
Add cross-platform CI with conda packages (minimal version)#1636rhaschke merged 40 commits intoros-visualization:noetic-develfrom
Conversation
rhaschke
left a comment
There was a problem hiding this comment.
Sorry for ignoring this PR for so long. I didn't have time to look into this yet.
Of course, I'm open to increase cross-platform compatibility and I agree to most of the changes here. However, I'm not sure we should establish a separate CI workflow. In MoveIt we experienced many false-positive alarms. So if you insist in this approach, please ensure that you fix all upstream dependencies to not experience false alarms.
src/rviz/default_plugin/interactive_markers/interactive_marker_control.h
Outdated
Show resolved
Hide resolved
|
Ok, that was definitely too early for me :) sorry. I should boot on Windows and see what's going on here. |
b47ab97 to
9e81c2c
Compare
|
I just merged |
rhaschke
left a comment
There was a problem hiding this comment.
Finally, some remarks to the workflow definition. Please rename some files:
.github/ci_cross_platform_env.yml->.github/robostack_env.yaml.github/workflows/cross_platform_ci.yml->.github/workflows/robostack.yaml.github/workflows/prerelease.yml->.github/workflows/prerelease.yaml
Fix as many versions as possible to reduce the risk of false-positives.
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
…on#1636) * Remove vendoring freetype and zlib Signed-off-by: Michael Carroll <carroll.michael@gmail.com> * Suggestions (ros-visualization#1638) Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> --------- Signed-off-by: Michael Carroll <carroll.michael@gmail.com> Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Description
This PR supersedes #1600 and introduces cross-platform CI for rviz using the RoboStack. It is a minimal set of changes, in particular it does not include changes from #1532 that should be discussed separately. It would be great to get some feedback from the rviz maintainers to see whether there is interest in getting this merged :)
/cc @wolfv
Checklist
YAMLorrosbagfile with aMarkerArraymsg.Due to the lack of active maintainers, we cannot provide support for older release branches anymore.