Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foxglove_msgs: update repo url #44646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amacneil
Copy link

@amacneil amacneil commented Mar 1, 2025

Please Add This Package to be indexed in the rosdistro.

foxglove_msgs

  • updated the repo URL
  • set status: developed consistently across all distros
  • added packages key to explicitly list the packages (we plan to add more in the future)

I'm not sure if the URL should be corrected for EOL distros, please let me know if you would prefer I revert those.

The source is here:

https://github.com/foxglove/foxglove-sdk/tree/main/ros/foxglove_msgs

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added end-of-life Issue/PR is to an End-of-Life distribution humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution noetic Issue/PR is for the ROS 1 Noetic distribution rolling Issue/PR is for the ROS 2 Rolling distribution labels Mar 1, 2025
Copy link

mergify bot commented Mar 1, 2025

This pull request changes files for a ROS distribution that is no longer supported (End Of Life) and the distribution will not have any future syncs to include this change.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@amacneil amacneil force-pushed the adrian/update-foxglove-msgs-repo branch from 44cd61a to 112be59 Compare March 1, 2025 03:24
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@amacneil amacneil force-pushed the adrian/update-foxglove-msgs-repo branch from 112be59 to 0b5629d Compare March 1, 2025 03:27
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Mar 4, 2025
@sloretz
Copy link
Contributor

sloretz commented Mar 4, 2025

Holding for Noetic sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
end-of-life Issue/PR is to an End-of-Life distribution held for sync Issue/PR has been held because the distribution is in a sync hold humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution noetic Issue/PR is for the ROS 1 Noetic distribution rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants