Add rosidl_rust to a sourced overlay in the docker image - #494
Merged
esteve merged 5 commits intoAug 15, 2025
Conversation
…rypoint. Move any logic that will change between distros into shell scripts for more flexibility.
esteve
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rosidl_rust in an overlay sourced in the dev container via an entrypoint.
Move any logic that will change between distros into shell scripts for more flexibility.
Rather than for ros2_rust development, I find this image most useful for downstream development of packages. This way I can just add
rclrsas a dep and everything "just works". There is probably a discussion to be had for moving this out of the repo as its morerclrsadjacent at this point.Tested locally for Humble, Jazzy, Kilted, and Rolling with our ros2_rust workspace (described in the README) with a
COLCON_IGNOREin thesrc/ros2-rust/rosidl_rust/rosidl_generator_rspackage.In the container