ci: add lint and package checks - #35
Open
esteve wants to merge 15 commits into
Open
Conversation
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
esteve
force-pushed
the
ci/add-lint-and-checks
branch
from
June 15, 2026 17:00
2b9946e to
fc9e4e5
Compare
Signed-off-by: Esteve Fernandez <esteve@apache.org>
esteve
force-pushed
the
ci/add-lint-and-checks
branch
from
June 15, 2026 17:02
fc9e4e5 to
2be188e
Compare
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
maspe36
pushed a commit
that referenced
this pull request
Aug 10, 2026
… index Generated interface crates opt into `ros-env` by default since #21 (`[package.metadata.ros-env] include = true` in the Cargo.toml template), which means they are `include!()`d from the source installed to `share/<pkg>/rust` rather than resolved as Cargo dependencies. The `rust_packages` ament index resource exists only so that `colcon-ros-cargo` can emit a `[patch.crates-io.<pkg>]` entry for packages that *are* real Cargo dependencies. Registering generated crates therefore produces a patch that nothing in the dependency graph uses, and Cargo records those as `[[patch.unused]]` in every consumer's `Cargo.lock`. That makes the lockfile depend on whichever interface packages happen to be present on the prefix: locks differ between machines and `--locked` builds fail on any extra patched crate. Stop registering the resource. The `install(DIRECTORY ...)` of the crate source is kept, since that is what `ros-env` reads from `AMENT_PREFIX_PATH`. This is the generator-side counterpart of cargo-ament-build PR #35, which already skips the same marker for `ament_cargo` packages that opt into `ros-env`. Verified with a two-package workspace (an `ament_cmake` interface package plus an `ament_cargo` node consuming it through `ros-env`) built with cargo-ament-build 0.1.11 and colcon-ros-cargo 0.2.0. Before the change the marker file, the `[patch.crates-io]` entry and a `[[patch.unused]]` block for the interface package are all present; after it all three are gone and the node still compiles and links. Note this is a behaviour change for consumers that still declare generated interface crates as direct Cargo dependencies: those relied on `colcon-ros-cargo` patching them in and should migrate to `ros-env`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.