Skip to content

Enable RMW isolation for single process tests - #983

Merged
ahcorde merged 3 commits into
rollingfrom
yadu/test_message_filter-rmw-isolation
Sep 3, 2026
Merged

Enable RMW isolation for single process tests#983
ahcorde merged 3 commits into
rollingfrom
yadu/test_message_filter-rmw-isolation

Conversation

@Yadunund

Copy link
Copy Markdown
Member

Description

#960 enabled RMW isolation for test_tf2 launch tests but not single process tests that call rclcpp::init / rclpy.init.

When testing with rmw_zenoh, those still connect to default tcp/localhost:7447 with an infinite peer connect timeout, so session open can hang and ctest reports gtest.missing_result.

That showed up as an intermittent zenoh nightly failure: 119 passed, 120 failed on test_message_filter with no source changes.

This PR wraps remaining ROS-init tests with the fixture:

  • test_tf2 / tf2_ros: ament_add_ros_isolated_gtest for gtests that call rclcpp::init
  • tf2_ros_py: session-scoped conftest.py (ament_python has no CMake isolated runner)

Fixes # (issue)

Is this user-facing behavior change?

No

Did you use Generative AI?

Yes. Cursor (Grok 4.6) for diagnosis and the isolation wiring.

Additional Information

Launch isolation from #960 is unchanged.

Signed-off-by: Yadunund Vijay <yadunund@gmail.com>
Signed-off-by: Yadunund Vijay <yadunund@gmail.com>
@Yadunund
Yadunund requested a review from cottsay August 31, 2026 21:22
Comment thread tf2_ros/CMakeLists.txt Outdated
Signed-off-by: Yadunund Vijay <yadunund@gmail.com>
@Yadunund
Yadunund force-pushed the yadu/test_message_filter-rmw-isolation branch from be2c219 to 9553415 Compare September 2, 2026 18:21

@cottsay cottsay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@Yadunund

Yadunund commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

CI started with: https://gist.githubusercontent.com/Yadunund/62882e88df23c7375068cc6bcad1691d/raw/e14b9f51eb6be6e070459a7888889a8953540e85/ros2.repos
BUILD_ARGS: --packages-up-to tf2_ros test_tf2 tf2_ros_py
TEST_ARGS: --packages-select tf2_ros test_tf2 tf2_ros_py
Launcher: https://ci.ros2.org/job/ci_launcher/20315/

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
ahcorde merged commit bcee5a2 into rolling Sep 3, 2026
1 check passed
@ahcorde
ahcorde deleted the yadu/test_message_filter-rmw-isolation branch September 3, 2026 07:05
@ahcorde

ahcorde commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

https://github.com/Mergifyio backport lyrical

@mergify

mergify Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

backport lyrical

✅ Backports have been created

Details

Cherry-pick of bcee5a2 has failed:

On branch mergify/bp/lyrical/pr-983
Your branch is up to date with 'origin/lyrical'.

You are currently cherry-picking commit bcee5a2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   tf2_ros/CMakeLists.txt
	modified:   tf2_ros/package.xml
	new file:   tf2_ros_py/conftest.py
	modified:   tf2_ros_py/package.xml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test_tf2/CMakeLists.txt
	both modified:   test_tf2/package.xml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants