-
Notifications
You must be signed in to change notification settings - Fork 448
Remove trailing whitespace #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see my comment on ros2/ros2_documentation#5203 (review)
This is almost certainly going to change existing files, right? Also, note that, given that we have a ton of repos, it would take a non-trivial amount of work to maintain this. |
if we enable this globally, yeah we need to to make sure all repos to pass the github action with pre-commit, that is the work. (my thought is that keep the github action under |
@ros-pull-request-builder retest this please |
1 similar comment
@ros-pull-request-builder retest this please |
Should I close this PR and open a new one in the ros2 repository, targeting each package individually? |
@leander-dsouza how would you want to process this? i think we can remove |
Signed-off-by: Leander Stephen D'Souza <[email protected]>
87945ae
to
0f6a1db
Compare
@fujitatomoya I have refactored the PR to remove the trailing whitespace :) |
Pulls: #2791 |
Description
I have added the following hooks as part of the pre-commit:
end-of-file-fixer
mixed-line-ending
trailing-whitespace
This prevents empty whitespace and additional newlines from registering as a separate commit during development.