Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Oct 15, 2025

Description

This PR adds the HistoryQoS to the entities discovery callback when available.
Related tests PRs

Fixes #684

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

Should be backported only to Kilted


This is an automatic backport of pull request #829 done by Mergify.

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e78f3f4)

# Conflicts:
#	rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/qos.hpp
@mergify
Copy link
Author

mergify bot commented Oct 15, 2025

Cherry-pick of e78f3f4 has failed:

On branch mergify/bp/humble/pr-829
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit e78f3f4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/qos.hpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Oct 15, 2025
@emersonknapp emersonknapp changed the title Retrieve HistoryQoS in discovery when available (backport #829) Retrieve HistoryQoS in discovery when available (humble backport #829) Oct 15, 2025
@emersonknapp emersonknapp self-assigned this Oct 15, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Nov 19, 2025

Pulls: #847
Gist: https://gist.githubusercontent.com/ahcorde/18a87dd8df3e16074825562fe0b1ce4d/raw/5864ad57574c9208edaddab6c915b6a09cb1cc69/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_fastrtps_shared_cpp
TEST args: --packages-above rmw_fastrtps_shared_cpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17547

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants