Skip to content

Conversation

@felixf4xu
Copy link
Contributor

Clarify Windows build command and permissions for symbolic links.

Description

Remove --symlink-install and add some instructions how to enable it.

Fixes #5120

Did you use Generative AI?

No

Additional Information

Copilot AI review requested due to automatic review settings October 15, 2025 07:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Windows build instructions for colcon by removing the --symlink-install flag and adding clarification about symbolic link permissions on Windows.

  • Removes --symlink-install from the default Windows build command
  • Adds explanation about Windows symbolic link permission requirements and how to enable them

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

felixf4xu and others added 3 commits December 9, 2025 19:59
Clarify Windows build command and permissions for symbolic links.

Signed-off-by: Felix F Xu <[email protected]>
@fujitatomoya fujitatomoya self-assigned this Dec 9, 2025
@fujitatomoya fujitatomoya added the backport-all backport at reviewers discretion; from rolling to all versions label Dec 9, 2025
@fujitatomoya fujitatomoya enabled auto-merge (squash) December 9, 2025 23:34
@fujitatomoya fujitatomoya merged commit b7312c8 into ros2:rolling Dec 9, 2025
5 checks passed
mergify bot pushed a commit that referenced this pull request Dec 9, 2025
* Update Windows colcon build instructions --symlink-install

Clarify Windows build command and permissions for symbolic links.

Signed-off-by: Felix F Xu <[email protected]>

* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Felix F Xu <[email protected]>

* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Felix F Xu <[email protected]>

---------

Signed-off-by: Felix F Xu <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
(cherry picked from commit b7312c8)
mergify bot pushed a commit that referenced this pull request Dec 9, 2025
* Update Windows colcon build instructions --symlink-install

Clarify Windows build command and permissions for symbolic links.

Signed-off-by: Felix F Xu <[email protected]>

* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Felix F Xu <[email protected]>

* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Felix F Xu <[email protected]>

---------

Signed-off-by: Felix F Xu <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
(cherry picked from commit b7312c8)
mergify bot pushed a commit that referenced this pull request Dec 9, 2025
* Update Windows colcon build instructions --symlink-install

Clarify Windows build command and permissions for symbolic links.

Signed-off-by: Felix F Xu <[email protected]>

* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Felix F Xu <[email protected]>

* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Felix F Xu <[email protected]>

---------

Signed-off-by: Felix F Xu <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
(cherry picked from commit b7312c8)
fujitatomoya added a commit that referenced this pull request Dec 9, 2025
…6076)

* Update Windows colcon build instructions --symlink-install

Clarify Windows build command and permissions for symbolic links.



* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst




* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst




---------




(cherry picked from commit b7312c8)

Signed-off-by: Felix F Xu <[email protected]>
Co-authored-by: Felix F Xu <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya added a commit that referenced this pull request Dec 9, 2025
…6077)

* Update Windows colcon build instructions --symlink-install

Clarify Windows build command and permissions for symbolic links.



* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst




* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst




---------




(cherry picked from commit b7312c8)

Signed-off-by: Felix F Xu <[email protected]>
Co-authored-by: Felix F Xu <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya added a commit that referenced this pull request Dec 9, 2025
…6078)

* Update Windows colcon build instructions --symlink-install

Clarify Windows build command and permissions for symbolic links.



* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst




* Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst




---------




(cherry picked from commit b7312c8)

Signed-off-by: Felix F Xu <[email protected]>
Co-authored-by: Felix F Xu <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

symlink-install on Windows 11 requires admin or Developer Mode. This should be in the colcon tutorial.

2 participants