-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update Windows colcon build instructions --symlink-install #5948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates Windows build instructions for colcon by removing the --symlink-install flag and adding clarification about symbolic link permissions on Windows.
- Removes
--symlink-installfrom the default Windows build command - Adds explanation about Windows symbolic link permission requirements and how to enable them
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fujitatomoya
requested changes
Oct 16, 2025
Clarify Windows build command and permissions for symbolic links. Signed-off-by: Felix F Xu <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Felix F Xu <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Felix F Xu <[email protected]>
fujitatomoya
approved these changes
Dec 9, 2025
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
* Update Windows colcon build instructions --symlink-install Clarify Windows build command and permissions for symbolic links. Signed-off-by: Felix F Xu <[email protected]> * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst Co-authored-by: Copilot <[email protected]> Signed-off-by: Felix F Xu <[email protected]> * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Felix F Xu <[email protected]> --------- Signed-off-by: Felix F Xu <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit b7312c8)
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
* Update Windows colcon build instructions --symlink-install Clarify Windows build command and permissions for symbolic links. Signed-off-by: Felix F Xu <[email protected]> * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst Co-authored-by: Copilot <[email protected]> Signed-off-by: Felix F Xu <[email protected]> * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Felix F Xu <[email protected]> --------- Signed-off-by: Felix F Xu <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit b7312c8)
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
* Update Windows colcon build instructions --symlink-install Clarify Windows build command and permissions for symbolic links. Signed-off-by: Felix F Xu <[email protected]> * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst Co-authored-by: Copilot <[email protected]> Signed-off-by: Felix F Xu <[email protected]> * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Felix F Xu <[email protected]> --------- Signed-off-by: Felix F Xu <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit b7312c8)
This was referenced Dec 9, 2025
fujitatomoya
added a commit
that referenced
this pull request
Dec 9, 2025
…6076) * Update Windows colcon build instructions --symlink-install Clarify Windows build command and permissions for symbolic links. * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst --------- (cherry picked from commit b7312c8) Signed-off-by: Felix F Xu <[email protected]> Co-authored-by: Felix F Xu <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Dec 9, 2025
…6077) * Update Windows colcon build instructions --symlink-install Clarify Windows build command and permissions for symbolic links. * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst --------- (cherry picked from commit b7312c8) Signed-off-by: Felix F Xu <[email protected]> Co-authored-by: Felix F Xu <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Dec 9, 2025
…6078) * Update Windows colcon build instructions --symlink-install Clarify Windows build command and permissions for symbolic links. * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst * Update source/Tutorials/Beginner-Client-Libraries/Colcon-Tutorial.rst --------- (cherry picked from commit b7312c8) Signed-off-by: Felix F Xu <[email protected]> Co-authored-by: Felix F Xu <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify Windows build command and permissions for symbolic links.
Description
Remove
--symlink-installand add some instructions how to enable it.Fixes #5120
Did you use Generative AI?
No
Additional Information