Skip to content

Update quaternion tutorial #6069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahcorde merged 6 commits into from
Dec 11, 2025
Merged

Update quaternion tutorial #6069

ahcorde merged 6 commits into from
Dec 11, 2025

Conversation

@azzamshaikh
Copy link
Contributor

@azzamshaikh azzamshaikh commented Dec 5, 2025

Description

Per Issue 6063, this PR revises the quaternion tutorial based on the issues noted below:

1 - The convention of quaternion representaion in an array in the function definition is [w,x,y,z] not consistent with the passed arrays [x,y,z,w].

2- It is mentioned that the inverse of a unit quaternion is simply the negation of w, which is incorrect, representing the quaternion as the array of [w,x,y,z], the inverse is [w, -x,-y,-z].

Fixes #6063

Did you use Generative AI?

No

@kscottz kscottz enabled auto-merge (squash) December 5, 2025 22:54
@kscottz kscottz self-requested a review December 5, 2025 22:55
kscottz
kscottz reviewed Dec 5, 2025
View reviewed changes
Copy link
Collaborator

@kscottz kscottz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The linter found some trailing white space that needs to get fixed.

@kscottz kscottz requested a review from ahcorde December 11, 2025 18:10
@ahcorde ahcorde added the backport-all backport at reviewers discretion; from rolling to all versions label Dec 11, 2025
@ahcorde ahcorde disabled auto-merge December 11, 2025 21:22
@ahcorde ahcorde enabled auto-merge (squash) December 11, 2025 21:22
@ahcorde ahcorde merged commit f08a6f9 into ros2:rolling Dec 11, 2025
5 checks passed
mergify bot pushed a commit that referenced this pull request Dec 11, 2025
@azzamshaikh @kscottz @mergify
Update quaternion tutorial (#6069)
d3924d1 
Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: kscottz <[email protected]>
(cherry picked from commit f08a6f9)
mergify bot pushed a commit that referenced this pull request Dec 11, 2025
@azzamshaikh @kscottz @mergify
Update quaternion tutorial (#6069)
7bd8b9e 
Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: kscottz <[email protected]>
(cherry picked from commit f08a6f9)
This was referenced Dec 11, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2025
@azzamshaikh @kscottz @mergify
Update quaternion tutorial (#6069)
1b3d36c 
Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: kscottz <[email protected]>
(cherry picked from commit f08a6f9)
@mergify mergify bot mentioned this pull request Dec 11, 2025
Merged
ahcorde pushed a commit that referenced this pull request Dec 11, 2025
@mergify @azzamshaikh @kscottz
Update quaternion tutorial (#6069) (#6088)
2eb44ea 
(cherry picked from commit f08a6f9)

Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: Azzam Shaikh <[email protected]>
Co-authored-by: kscottz <[email protected]>
ahcorde pushed a commit that referenced this pull request Dec 11, 2025
@mergify @azzamshaikh @kscottz
Update quaternion tutorial (#6069) (#6089)
bc8ceef 
(cherry picked from commit f08a6f9)

Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: Azzam Shaikh <[email protected]>
Co-authored-by: kscottz <[email protected]>
ahcorde pushed a commit that referenced this pull request Dec 11, 2025
@mergify @azzamshaikh @kscottz
Update quaternion tutorial (#6069) (#6090)
86e9c7c 
(cherry picked from commit f08a6f9)

Signed-off-by: Katherine Scott <[email protected]>
Co-authored-by: Azzam Shaikh <[email protected]>
Co-authored-by: kscottz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kscottz kscottz kscottz left review comments

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

📝 some mistakes on the quaternion tutorial

3 participants

@azzamshaikh @kscottz @ahcorde