-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add XML/YAML launch equivalents for large project tutorial (backport #6021) #6087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Luke Sy <[email protected]> Signed-off-by: Katherine Scott <[email protected]> Co-authored-by: Katherine Scott <[email protected]> (cherry picked from commit 536c723) # Conflicts: # source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
|
Cherry-pick of 536c723 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
ahcorde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsy3 do you have some time to review the conflicts ?
Remove conflict markers, keep multi-format references, and fix PushRosNamespace capitalization. Signed-off-by: Luke Sy <[email protected]>
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/20162042847/artifacts/4848429007. To view the resulting site:
|
|
@kscottz or @fujitatomoya can you merge this one ? |
Description
Add XML/YAML launch file equivalents "Using ROS 2 Launch For Large Projects" tutorial.
Fixes #6006
Did you use Generative AI?
Partially - Cursor AI Assistant for tutorial rephrasing and refactoring. Each generated line reviewed.
Additional Information
broadcast_listener_launch.pyrenamed tobroadcaster_listener_launch.pyfor correctness for launch file nameTutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.html. If 📝 Replace all trivial launchfile examples with XML/YAML #6006 includes changes totfandurdftutorial, they will be done so in a separate PR.This is an automatic backport of pull request #6021 done by [Mergify](https://mergify.com).