Add --build-type ament_cmake to action tutorial #6179
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Creating-an-Action tutorial was missing the --build-type flag when creating the interface package. This could lead users to accidentally create an ament_python package, which cannot contain interface definitions (msg, srv, or action files). This change: - Adds --build-type ament_cmake to the ros2 pkg create command - Adds a note explaining that interface packages must be CMake packages - Adds a best practice note about separating interfaces into their own packages Closes ros2#4986 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--build-type ament_cmakeflag to theros2 pkg createcommand in the Creating-an-Action tutorialThis aligns the action tutorial with the Custom-ROS2-Interfaces tutorial, which already includes this flag and explanation.
Closes #4986
Test plan
sphinx-lintpasses🤖 Generated with Claude Code