Skip to content

Allow deprecating fields of interfaces - #145

Open
InvincibleRMC wants to merge 2 commits into
rollingfrom
rmc/deprecate-fields
Open

Allow deprecating fields of interfaces#145
InvincibleRMC wants to merge 2 commits into
rollingfrom
rmc/deprecate-fields

Conversation

@InvincibleRMC

@InvincibleRMC InvincibleRMC commented Mar 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Description

Proposes adding support for annotatoins with the form @deprecated ( text='foo' ).

For now only supports .idl since this shouldn't happen often. This method allows us to add support in the future if we desire.

Fixes ros2/ros2#1679

Note: I can do python also if this methodology is approved.

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

@InvincibleRMC
Add DISABLE_DEPRECATED_PUSH/POP
b4f1825 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC

InvincibleRMC commented Mar 18, 2026

Copy link
Copy Markdown
Author

Pulls: ros2/rosidl#945, #145
Gist: https://gist.githubusercontent.com/InvincibleRMC/8324eb73e25ffbbb22757567c7780d8d/raw/e2297a0c6e2aca964e6406ba63beb6b02477dc3d/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_c rosidl_generator_cpp rosidl_parser rosidl_generator_tests rosidl_runtime_c rosidl_typesupport_introspection rosidl_typesupport_fastrtps_cpp
TEST args: --packages-above rosidl_generator_c rosidl_generator_cpp rosidl_parser rosidl_generator_tests rosidl_runtime_c rosidl_typesupport_introspection rosidl_typesupport_fastrtps_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18545

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC InvincibleRMC mentioned this pull request Mar 18, 2026
Open
@InvincibleRMC

InvincibleRMC commented Mar 18, 2026

Copy link
Copy Markdown
Author

Pulls: ros2/rosidl#945, #145
Gist: https://gist.githubusercontent.com/InvincibleRMC/722adcc3d2011fa39540f64f251d65df/raw/e2297a0c6e2aca964e6406ba63beb6b02477dc3d/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_c rosidl_generator_cpp rosidl_parser rosidl_generator_tests rosidl_runtime_c rosidl_typesupport_introspection_cpp rosidl_typesupport_fastrtps_cpp
TEST args: --packages-above rosidl_generator_c rosidl_generator_cpp rosidl_parser rosidl_generator_tests rosidl_runtime_c rosidl_typesupport_introspection_cpp rosidl_typesupport_fastrtps_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18549

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Add C support
7f40162 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC

InvincibleRMC commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Pulls: ros2/rosidl#945, #145
Gist: https://gist.githubusercontent.com/InvincibleRMC/121d0ef53beee6d66aefdfb2eec72c97/raw/e2297a0c6e2aca964e6406ba63beb6b02477dc3d/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_c rosidl_generator_cpp rosidl_parser rosidl_generator_tests rosidl_runtime_c rosidl_typesupport_introspection_cpp rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp
TEST args: --packages-above rosidl_generator_c rosidl_generator_cpp rosidl_parser rosidl_generator_tests rosidl_runtime_c rosidl_typesupport_introspection_cpp rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18566

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Rebuild

  • Linux Build Status

  • Linux-rhel Build Status

@InvincibleRMC

InvincibleRMC commented Mar 20, 2026

Copy link
Copy Markdown
Author

Pulls: ros2/rosidl#945, #145
Gist: https://gist.githubusercontent.com/InvincibleRMC/3734099820e7dcc6682c9b2b7c2b83e8/raw/e2297a0c6e2aca964e6406ba63beb6b02477dc3d/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_c rosidl_generator_cpp rosidl_parser rosidl_generator_tests rosidl_runtime_c rosidl_typesupport_introspection_cpp rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp
TEST args: --packages-above rosidl_generator_c rosidl_generator_cpp rosidl_parser rosidl_generator_tests rosidl_runtime_c rosidl_typesupport_introspection_cpp rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18570

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
InvincibleRMC marked this pull request as ready for review March 20, 2026 01:41
@InvincibleRMC InvincibleRMC changed the title Add DISABLE_DEPRECATED_PUSH/POP Allow deprecating fields of interfaces Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sloretz sloretz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add deprecation of interface variables

2 participants

@InvincibleRMC @sloretz