Control shared/static typesupport libraries build via CMake variable (backport #138) - #148
Open
mergify[bot] wants to merge 1 commit into
Open
Control shared/static typesupport libraries build via CMake variable (backport #138)#148mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: Jay Sridharan <jsridharan@relativityspace.com> Co-authored-by: Jay Sridharan <jsridharan@relativityspace.com> (cherry picked from commit 82f41be)
ahcorde
approved these changes
Mar 19, 2026
Contributor
|
Pulls: #148
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If my CMake project has
set(BUILD_SHARED_LIBS OFF)to prefer libraries be built and linked statically, the typesupport libraries still need to be built as shared object since they are loaded at runtime. This PR adds an explicit SHARED declaration to the add_library calls to avoid static libraries being generated.Is this user-facing behavior change?
Yes, but there should be no negative impact because these typesupport libraries are ALWAYS supposed to be shared objects.
Did you use Generative AI?
No
Additional Information
This change should be backported to humble, jazzy and kilted as well.
This is an automatic backport of pull request #138 done by Mergify.