Skip to content

Fixed crash when raycasting while map is updated#1034

Open
ahcorde wants to merge 2 commits intorollingfrom
ahcorde/map-crash-on-raycast
Open

Fixed crash when raycasting while map is updated#1034
ahcorde wants to merge 2 commits intorollingfrom
ahcorde/map-crash-on-raycast

Conversation

@ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 15, 2023

Related with this PR https://github.com/ros-visualization/rviz/pull/1793/files in RViz for ROS 1

@ahcorde
Fixed crash when raycasting while map is updated
d0e01a7 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Aug 15, 2023
@ahcorde ahcorde requested a review from mjcarroll May 21, 2025 10:02
@ahcorde
Copy link
Contributor Author

ahcorde commented May 21, 2025

Pulls: #1034
Gist: https://gist.githubusercontent.com/ahcorde/9cf9e6ec0def2004bd2d350dbea1e15c/raw/d70682359513b14f49e28ed49706018c337064dc/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_default_plugins
TEST args: --packages-above rviz_default_plugins
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16058

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde requested a review from sloretz June 6, 2025 07:59
@ahcorde ahcorde requested a review from asymingt June 27, 2025 07:50
asymingt
asymingt approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@asymingt asymingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde
Copy link
Contributor Author

ahcorde commented Jun 27, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor

sloretz commented Jun 27, 2025

Might need a new repos file. I see the last CI has ros/urdfdom_headers at master branch https://gist.githubusercontent.com/ahcorde/9cf9e6ec0def2004bd2d350dbea1e15c/raw/d70682359513b14f49e28ed49706018c337064dc/ros2.repos , but that should be rolling branch as of ros2/ros2#1701 .

@ahcorde
Copy link
Contributor Author

ahcorde commented Jun 30, 2025

Pulls: #1034
Gist: https://gist.githubusercontent.com/ahcorde/e757f28346840f24cdd39a01da054120/raw/efa1eed68add3e86436861e7270114276baf0071/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_default_plugins
TEST args: --packages-above rviz_default_plugins
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16354

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asymingt asymingt asymingt approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

@sloretz sloretz Awaiting requested review from sloretz

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @sloretz @asymingt