Check non-uppercase variable when missing import target#30
Closed
f0reachARR wants to merge 2 commits intoros2:rollingfrom
Closed
Check non-uppercase variable when missing import target#30f0reachARR wants to merge 2 commits intoros2:rollingfrom
f0reachARR wants to merge 2 commits intoros2:rollingfrom
Conversation
Signed-off-by: f0reachARR <f0reach@f0reach.me>
Signed-off-by: f0reachARR <f0reach@f0reach.me>
59479f2 to
08519ed
Compare
Member
|
Hi @f0reachARR 👋 It looks like you are using a non-standard cmake module to search for |
Author
|
Thanks for reply and suggestion! That makes sense: it's better to avoid to handle edge-cases in ROS packages. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the error message
Unable to extract the library file path from, which occurs under specific conditions.This issue happens when the following two conditions are met:
FindTinyXML2.cmakeintinyxml2_vendor.TinyXML2_LIBRARYinstead of the expected uppercaseTINYXML2_LIBRARY.This edge case was identified in tier4/scenario_simulator_v2#1604. Specifically, the transitive dependency
mrt_cmake_modulesprovides its ownFindTinyXML2.cmake, which triggers this problem.To resolve this, I have modified the logic to check for non-uppercase variables (including
TinyXML2_LIBRARY) as a fallback ifTINYXML2_LIBRARYis not defined.Is this a user-facing behavior change?
This does not affect almost use cases, but it requires careful review to ensure compatibility.
Did you use Generative AI?
No
Additional Information