Skip to content

fix: background color for hover and selected elements in the sidebar … #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

IamGianluca
Copy link
Contributor

…is properly displayed

This PR fixes an issue where the background color for elements in the sidebar does not respect the theme.

Without this fix:
image

With this fix:
image

In this PR I've only fixed the main theme. I'll also fix the other two themes, but I wanted some feedback since I'm new to GTK theming, and perhaps there is a better way of accomplishing what I did. The changes I made are a departure from the standard @define-color <variable name> <hexadecimal color>;. Are you okay with this?

@IamGianluca
Copy link
Contributor Author

I've updated also the other two themes.

@IamGianluca IamGianluca force-pushed the main branch 3 times, most recently from 0a3c414 to da395e3 Compare March 5, 2025 01:33
@IamGianluca
Copy link
Contributor Author

IamGianluca commented Mar 5, 2025

One more update: I figured out how to set the color for the background when hovering over using the hex format instead of rgba. rgba(196, 167, 231, 0.2) is equal to #c4a7e7 with 0.2 opacity. However, background and foreground colors become semi-transparent when using the latter format in CSS, so you can't read the text. The solution was to use the equivalent format #c4a7e733.

I've updated the PR to keep the code more consistent.

@IamGianluca
Copy link
Contributor Author

@ThatOneCalculator let me know if you have any feedback

@IamGianluca
Copy link
Contributor Author

Hi, apologies for bringing attention to the PR after one month. Would it be possible to merge it? I use this GTK theme on multiple machines and would love to use this repo instead of my fork. I think most users would also benefit from having the sidebar display the correct colors.

Many thanks and thank you again for your work! I love the rose-pine eco-system :-)

@ThatOneCalculator ThatOneCalculator merged commit b1a8253 into rose-pine:main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants