fix: background color for hover and selected elements in the sidebar … #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated also the other two themes. |
IamGianluca
force-pushed
the
main
branch
3 times, most recently
from
0a3c414 to
da395e3
Compare
|
One more update: I figured out how to set the color for the background when hovering over using the hex format instead of rgba. I've updated the PR to keep the code more consistent. |
…at are hovered or selected
|
@ThatOneCalculator let me know if you have any feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is properly displayed
This PR fixes an issue where the background color for elements in the sidebar does not respect the theme.
Without this fix:
With this fix:
In this PR I've only fixed the main theme. I'll also fix the other two themes, but I wanted some feedback since I'm new to GTK theming, and perhaps there is a better way of accomplishing what I did. The changes I made are a departure from the standard
@define-color <variable name> <hexadecimal color>;. Are you okay with this?