roseteromeo56/dogecoin

[roseteromeo56]

Romeo Rosete

[Copilot]

Pull Request Overview

This PR updates the Dogecoin authentication configuration by writing the generated credentials to dogecoin.conf instead of printing them to stdout, and it ensures that GitHub Actions workflows have the appropriate read permissions for repository contents.

• Replaces printed messages with secure file writing in rpcuser.py.
• Adds "contents: read" permissions to the linter and CI workflow YAML files.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
share/rpcuser/rpcuser.py	Updates authentication output to securely write to dogecoin.conf and inform the user.
.github/workflows/linter.yml	Adds permissions to allow read access to repository contents.
.github/workflows/ci.yml	Adds permissions to allow read access to repository contents.

[Copilot]

Consider adding error handling around file I/O operations to gracefully handle potential issues such as permission errors or disk write failures.

Suggested change

	print('String has been securely written to dogecoin.conf:')
	with open('dogecoin.conf', 'a') as conf_file:
	conf_file.write(f'rpcauth={username}:{salt}${password_hmac}\n')
	try:
	with open('dogecoin.conf', 'a') as conf_file:
	conf_file.write(f'rpcauth={username}:{salt}${password_hmac}\n')
	print('String has been securely written to dogecoin.conf:')
	except (IOError, OSError) as e:
	sys.stderr.write(f'Error writing to dogecoin.conf: {e}\n')
	sys.exit(1)