Patch 2#9
Merged
roseteromeo56 merged 54 commits intoJun 19, 2025
Merged
Conversation
Romeo Rosete
Romeo Rosete
Romeo Rosete
…ccae3f4d8c9fa1079a3ec38f33681bbeaa2e51b5fecd0857a0b2850014228044e7a132.js.download Romeo Rosete
Romeo Rosete
Romeo Rosete
Romeo Rosete
roseteromeo56/dogecoin
Romeo Rosete
Romeo Rosete
Romeo Rosete
roseteromeo56/dogecoin
roseteromeo56/dogecoin
Romeo Rosete
Romeo Rosete
Romeo Rosete
Romeo Rosete
roseteromeo56.cb.id/dogecoin
roseteromeo56/dogecoin
Romeo Rosete
Romeo Rosete
roseteromeo56/dogecoin
Romeo Rosete
….css Romeo Rosete
Romeo Rosete
Romeo Rosete
Romeo Rosete
roseteromeo56/dogecoin
roseteromeo56.cb.id/dogecoin
…nsitive information Romeo Rosete Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Potential fix for code scanning alert no. 8: Clear-text logging of sensitive information
…nsitive information Romeo Rosete Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Potential fix for code scanning alert no. 9: Clear-text logging of sensitive information
…n permissions Romeo Rosete Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Potential fix for code scanning alert no. 3: Workflow does not contain permissions
…n permissions Romeo Rosete Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Potential fix for code scanning alert no. 2: Workflow does not contain permissions
roseteromeo56/dogecoin
Romeo Rosete
roseteromeo56.cb.id/dogecoin
roseteromeo56
added
Dependencies
There was a problem hiding this comment.
Pull Request Overview
This PR updates the RPC user setup to write credentials directly into dogecoin.conf and adds front-end asset files (CSS and JS) for styling and functionality.
- Replace stdout prints in
rpcuser.pywith appendingrpcauthlines todogecoin.confand updated user prompts. - Introduce a new normalized CSS file, jQuery library, and flag-icon stylesheet.
Reviewed Changes
Copilot reviewed 14 out of 34 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| share/rpcuser/rpcuser.py | Write rpcauth line to dogecoin.conf instead of printing to stdout |
| main.ac65923dd5f8c0a60e44323e7a54ef8d988e681a843b8941a51ae6912fdaec78.css | Add normalize.css import and custom theme overrides |
| jquery.min.js.download | Add jQuery v3.6.0 minified script |
| flag-icon.min.css | Add flag-icon CSS for country flag support |
Comments suppressed due to low confidence (1)
share/rpcuser/rpcuser.py:35
- Consider adding a unit or integration test to verify that the
rpcauthline is correctly appended todogecoin.confand that existing content isn’t overwritten.
with open('dogecoin.conf', 'a') as conf_file:
| print(f'rpcauth={username}:{salt}${password_hmac}') | ||
| print(f'Your password:\n{password}') | ||
| print('String has been securely written to dogecoin.conf:') | ||
| with open('dogecoin.conf', 'a') as conf_file: |
There was a problem hiding this comment.
Appending credentials with default permissions may expose them to other users; set restrictive file permissions (e.g., mode=0o600) or adjust the umask to secure dogecoin.conf.
Comment on lines
+34
to
+35
| print('String has been securely written to dogecoin.conf:') | ||
| with open('dogecoin.conf', 'a') as conf_file: |
There was a problem hiding this comment.
[nitpick] Extract the filename 'dogecoin.conf' into a constant or configuration option instead of hardcoding it, to make future changes easier.
Suggested change
| print('String has been securely written to dogecoin.conf:') | |
| with open('dogecoin.conf', 'a') as conf_file: | |
| print(f'String has been securely written to {CONFIG_FILENAME}:') | |
| with open(CONFIG_FILENAME, 'a') as conf_file: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Romeo Rosete