Skip to content

feat: bump to net 10 - #124

Merged
OleRoss merged 3 commits into
mainfrom
feat/bump-to-net-10
May 6, 2026
Merged

feat: bump to net 10#124
OleRoss merged 3 commits into
mainfrom
feat/bump-to-net-10

Conversation

@OleRoss

@OleRoss OleRoss commented May 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Net 10 is the latest version. We should support it. Dropping net9.0 as it will be in support for only 6 more months

Changes

  • Changed net9.0 target to net10
  • Bumped all dependencies

Impact

Breaks all net9.0 projects

Checklist

  • PR is scoped and not oversized
  • Documentation (and changelog) is updated if needed
  • CI Pipeline is successful
  • Self-review was done

@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1ad7be8d-8282-4b9d-9723-3c2300785273

📥 Commits

Reviewing files that changed from the base of the PR and between 8314693 and e95c8b8.

📒 Files selected for processing (2)
  • test/Darp.Ble.WinRT.Tests/Darp.Ble.WinRT.Tests.csproj
  • test/Darp.Ble.WinRT.Tests/UnitTest1.cs
💤 Files with no reviewable changes (2)
  • test/Darp.Ble.WinRT.Tests/Darp.Ble.WinRT.Tests.csproj
  • test/Darp.Ble.WinRT.Tests/UnitTest1.cs

📝 Walkthrough

Walkthrough

Upgrades project infra to .NET 10: bumps SDK pin in global.json, updates central package versions in Directory.Packages.props, and moves multiple projects from .NET 8/9 to .NET 10. README Android build snippet updated; one WinRT test project and its tests were removed.

Changes

.NET Version Upgrade

Layer / File(s) Summary
SDK & Package Foundation
global.json, Directory.Packages.props
global.json SDK version pin changed 10.0.010.0.100. Central package versions updated (notably coverlet.collector 8.0.1→10.0.0, Darp.Utils.Messaging 1.19.2→1.20.0, Meziantou.Analyzer 3.0.48→3.0.61, logging packages 10.0.6→10.0.7, Microsoft.NET.Test.Sdk 18.4.0→18.5.1, Verify/Verify.XunitV3 31.15.0→31.16.2, YamlDotNet 17.0.1→17.1.0, System.Linq.Async 7.0.0→7.0.1, etc.).
Project Target Frameworks
src/.../*.csproj, tools/.../*.csproj
Multiple projects retargeted to .NET 10: src/Darp.Ble.Android net9.0-android→net10.0-android; src/Darp.Ble.Hci, Darp.Ble.HciHost, Darp.Ble.Mock net9.0→net10.0; src/Darp.Ble.WinRT net9.0;net9.0-windows... → net10.0;net10.0-windows... (and adjusted conditional ItemGroup); src/Darp.Ble changed from multi-target net9.0;net10.0 → single net10.0; tools/AssignedNumbersCrawler net8.0→net10.0.
Test Project Removal
test/Darp.Ble.WinRT.Tests/Darp.Ble.WinRT.Tests.csproj, test/Darp.Ble.WinRT.Tests/UnitTest1.cs
Removed the WinRT test project file and deleted the UnitTest1 test class and its methods.
Documentation
README.md
Android setup snippet updated to build for -f net10.0-android and added dotnet workload restore step.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: bump to net 10' clearly and concisely summarizes the main change: upgrading the project's target framework from .NET 9.0 to .NET 10.0.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation for upgrading to .NET 10, listing the key changes made, and documenting the impact on downstream projects.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Repo Coverage

Line Coverage Branch Coverage


PR Coverage

0/0 changed lines covered


Generated by coverage-pr-comment

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Directory.Packages.props (1)

8-11: Align test project to use central coverlet.collector version management.

The central Directory.Packages.props declares coverlet.collector at version 10.0.0 (line 8), but test/Darp.Ble.WinRT.Tests/Darp.Ble.WinRT.Tests.csproj explicitly pins it to 6.0.0, which overrides the central version and creates version fragmentation across the test suite.

Proposed alignment
-<PackageReference Include="coverlet.collector" Version="6.0.0" />
+<PackageReference Include="coverlet.collector" />
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Directory.Packages.props` around lines 8 - 11, The test project
Darp.Ble.WinRT.Tests (Darp.Ble.WinRT.Tests.csproj) explicitly pins
coverlet.collector to Version="6.0.0", which overrides the central declaration
in Directory.Packages.props (PackageVersion Include="coverlet.collector"
Version="10.0.0"); remove the inline Version attribute from the PackageReference
for coverlet.collector in Darp.Ble.WinRT.Tests.csproj so it inherits the central
version, preserving any existing PrivateAssets/IncludeAssets child elements if
present (i.e., keep the PackageReference and its metadata but delete the
Version="6.0.0" bit) to eliminate version fragmentation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Directory.Packages.props`:
- Around line 8-11: The test project Darp.Ble.WinRT.Tests
(Darp.Ble.WinRT.Tests.csproj) explicitly pins coverlet.collector to
Version="6.0.0", which overrides the central declaration in
Directory.Packages.props (PackageVersion Include="coverlet.collector"
Version="10.0.0"); remove the inline Version attribute from the PackageReference
for coverlet.collector in Darp.Ble.WinRT.Tests.csproj so it inherits the central
version, preserving any existing PrivateAssets/IncludeAssets child elements if
present (i.e., keep the PackageReference and its metadata but delete the
Version="6.0.0" bit) to eliminate version fragmentation.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d2052b5d-3dab-4e11-8052-b9470d722adf

📥 Commits

Reviewing files that changed from the base of the PR and between 18edad4 and 8314693.

📒 Files selected for processing (10)
  • Directory.Packages.props
  • README.md
  • global.json
  • src/Darp.Ble.Android/Darp.Ble.Android.csproj
  • src/Darp.Ble.Hci/Darp.Ble.Hci.csproj
  • src/Darp.Ble.HciHost/Darp.Ble.HciHost.csproj
  • src/Darp.Ble.Mock/Darp.Ble.Mock.csproj
  • src/Darp.Ble.WinRT/Darp.Ble.WinRT.csproj
  • src/Darp.Ble/Darp.Ble.csproj
  • tools/AssignedNumbersCrawler/AssignedNumbersCrawler.csproj

@OleRoss
OleRoss merged commit 74445b3 into main May 6, 2026
3 checks passed
@OleRoss
OleRoss deleted the feat/bump-to-net-10 branch May 6, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants