feat: bump to net 10 - #124
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughUpgrades project infra to .NET 10: bumps SDK pin in Changes.NET Version Upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Directory.Packages.props (1)
8-11: Align test project to use centralcoverlet.collectorversion management.The central
Directory.Packages.propsdeclarescoverlet.collectorat version10.0.0(line 8), buttest/Darp.Ble.WinRT.Tests/Darp.Ble.WinRT.Tests.csprojexplicitly pins it to6.0.0, which overrides the central version and creates version fragmentation across the test suite.Proposed alignment
-<PackageReference Include="coverlet.collector" Version="6.0.0" /> +<PackageReference Include="coverlet.collector" />🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Directory.Packages.props` around lines 8 - 11, The test project Darp.Ble.WinRT.Tests (Darp.Ble.WinRT.Tests.csproj) explicitly pins coverlet.collector to Version="6.0.0", which overrides the central declaration in Directory.Packages.props (PackageVersion Include="coverlet.collector" Version="10.0.0"); remove the inline Version attribute from the PackageReference for coverlet.collector in Darp.Ble.WinRT.Tests.csproj so it inherits the central version, preserving any existing PrivateAssets/IncludeAssets child elements if present (i.e., keep the PackageReference and its metadata but delete the Version="6.0.0" bit) to eliminate version fragmentation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Directory.Packages.props`:
- Around line 8-11: The test project Darp.Ble.WinRT.Tests
(Darp.Ble.WinRT.Tests.csproj) explicitly pins coverlet.collector to
Version="6.0.0", which overrides the central declaration in
Directory.Packages.props (PackageVersion Include="coverlet.collector"
Version="10.0.0"); remove the inline Version attribute from the PackageReference
for coverlet.collector in Darp.Ble.WinRT.Tests.csproj so it inherits the central
version, preserving any existing PrivateAssets/IncludeAssets child elements if
present (i.e., keep the PackageReference and its metadata but delete the
Version="6.0.0" bit) to eliminate version fragmentation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d2052b5d-3dab-4e11-8052-b9470d722adf
📒 Files selected for processing (10)
Directory.Packages.propsREADME.mdglobal.jsonsrc/Darp.Ble.Android/Darp.Ble.Android.csprojsrc/Darp.Ble.Hci/Darp.Ble.Hci.csprojsrc/Darp.Ble.HciHost/Darp.Ble.HciHost.csprojsrc/Darp.Ble.Mock/Darp.Ble.Mock.csprojsrc/Darp.Ble.WinRT/Darp.Ble.WinRT.csprojsrc/Darp.Ble/Darp.Ble.csprojtools/AssignedNumbersCrawler/AssignedNumbersCrawler.csproj
Summary
Net 10 is the latest version. We should support it. Dropping net9.0 as it will be in support for only 6 more months
Changes
Impact
Breaks all net9.0 projects
Checklist