Use prettier to enforce a consistent style for future contributors #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@GenieTim Do you know enough about Git Hooks to make this run on pre-commit? I can probably figure it out, but if you have the knowledge and can do it quickly that would be really cool. Don't worry if not though. Really appreciate what you have done here. 🙌 |
Contributor
|
I do have some experience, but mostly by using further tools, enabling the hooks to be installed automatically e.g. when installing other dependencies. Prettier has a whole page on possibilities (https://prettier.io/docs/en/precommit.html), my suggestion would be their second one. I exemplarily set it up in #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of #15 but one that I have write access to and can update before merging.