Single moment range support and adjacent new ranges intersection interpretation #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion new interpretation
* Added a whole set of unit test for single moment ranges (start == end)
* New interpretation of intersect operation through option.adjacent:true parameter (same behaviour assured if no parameter or false value). In such case, {---}[---] adjacent ranges, returns a single moment range at the union point
|
Hey @franjuan, could you explain why we'd need single moment ranges? I can't see the advantage over just using a moment object. |
Author
|
Well, I would like to work indistinctly with ranges and moments, understandind that a Moment is a range of a single point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single moment range support and testing and adjacent ranges intersection new interpretation
Thank you