Remove inline Javascript, part I #9513
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Popyllol-master
* enable phpstan bleading edge * gen baseline using CI * Revert "gen baseline using CI" * fix baseline * enable phpstan strict rules * gen baseline using CI * Revert "gen baseline using CI"
This allows to call it on specific elements only, e.g. after they've been inserted late to the DOM.
There's no apparent reason for them to be static, and no explanation, but as instance methods they are directly callable from the de-inlined event-handlers and we save some helper methods, which is good.
This make it easier for the calling code.
Have to repeat attaching event handlers after a clone().
This allows to strip 'unsafe-eval' from the CSP.
innerHTML requires 'unsafe-eval' in the CSP, while innerText doesn't.
If the last argument to a data-on* attribute is an object (associative array in PHP), it is used as options, which allow to specify if preventDefault() should be called on the event. This is relevant for some parts of the code and got lost in previous changes.
pabzm
force-pushed
the
extract-inline-js
branch
from
72cfd49 to
fedc7d2
Compare
|
(Rebased to latest of "master") |
2 tasks
|
@alecpl I would really appreciate if you would take the time to reply again on this topic. Just getting the ball dropped is a pretty frustrating collaboration experience. |
|
I'll need more time. Maybe @johndoh have some thoughts on this. |
pabzm
force-pushed
the
extract-inline-js
branch
from
fedc7d2 to
b737876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #9508 here's a change that removes
add_script()and transportsjs_commandsin JSON, which then gets interpreted as callbacks to call with given arguments, instead ofevaling strings.This does not tackle the many inline event handlers, in order to keep it manageable.