Skip to content

Add useful links in About #9720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add useful links in About #9720

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8166db6
Add useful links in About
nclm Nov 28, 2024
ecad5ed
Update phrasing for documentation
nclm Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions program/actions/settings/about.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,13 @@ public function run($args = [])
return 'Copyright © The Roundcube Dev Team';
},
'license' => static function () {
return 'This program is free software; you can redistribute it and/or modify it under the terms '
. 'of the <a href="http://www.gnu.org/licenses/gpl.html" target="_blank">GNU General Public License</a> '
. 'as published by the Free Software Foundation, either version 3 of the License, '
. 'or (at your option) any later version.<br/>'
. 'Some <a href="https://roundcube.net/license" target="_blank">exceptions</a> '
. 'for skins &amp; plugins apply.';
return 'This webmail is powered by <a href="https://roundcube.net" target="_blank">Roundcube</a>, a fully-featured browser-based e-mail client. '
. 'You can find help and further documentation in <a href="https://docs.roundcube.net" target="_blank">the user guide</a>.'
. '<br/><br/>'
. 'Roundcube is free software. You can <a href="https://roundcube.net/contribute/" target="_blank">contribute to improve it</a> '
. 'and redistribute it and/or modify it under the terms of the <a href="http://www.gnu.org/licenses/gpl.html" target="_blank">GNU General Public License</a> '
. 'as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. '
. 'Some <a href="https://roundcube.net/license" target="_blank">exceptions</a> for skins and plugins apply.';
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few issues with this:

  1. Documentation is not license, so probably would be better to separate license info from the "about and doc" info. I.e. leave the "license" content as it was, but provide an additional template handler.
  2. People may have the help plugin configured to direct to a different documentation URL. Maybe do not include this new element if the plugin is enabled?
  3. I think the "contribute" part is not needed at all.
  4. Providing users with more links they can follow may increase number of support request from them on our side. We don't want that.

]);

Expand Down
Loading