feat(antigravity): add Gemini 3.8 Flash support - #5423
Conversation
Co-authored-by: Wine Fox <fox@ling.plus>
|
This pull request targeted The base branch has been automatically changed to |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
The PR description claims minimal is rejected, but existing thinking validation can clamp unsupported levels in some request paths, so the documented behavior should be aligned with actual behavior or the validation adjusted.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds Gemini 3.8 Flash support to the static Antigravity model catalog, publishing its token limits, supported modalities, and thinking-level capabilities, plus a registry contract test to ensure the metadata remains stable.
Changes:
- Added a new Antigravity model definition for
gemini-3.8-flash-highwith 1,048,576 context / 65,536 output token limits and text/image/audio/video inputs. - Restricted advertised thinking levels to
low/medium/highfor Gemini 3.8 Flash in the static catalog. - Added a contract test validating the model identity and capabilities.
File summaries
| File | Description |
|---|---|
| internal/registry/models/models.json | Registers the gemini-3.8-flash-high Antigravity model with token limits, thinking levels, and supported modalities. |
| internal/registry/model_definitions_test.go | Adds a contract test asserting the new model is present and its metadata matches expectations. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if got.Thinking == nil || got.Thinking.Min != 1 || got.Thinking.Max != 65535 || !got.Thinking.DynamicAllowed { | ||
| t.Fatalf("Gemini 3.8 Flash thinking metadata = %+v", got.Thinking) | ||
| } | ||
| if want := []string{"low", "medium", "high"}; !slices.Equal(got.Thinking.Levels, want) { | ||
| t.Fatalf("Gemini 3.8 Flash thinking levels = %v, want %v", got.Thinking.Levels, want) | ||
| } |
Co-authored-by: Wine Fox <fox@ling.plus>
Summary
gemini-3.8-flash-highandgemini-3.8-flash-mediumrouteslow,medium, andhighthinking levels; Gemini 3.8 Flash rejectsminimalSource distinction
gemini-3.8-flash-high; this change synchronizes that metadata into the embedded catalog.gemini-3.8-flash-medium. The paired models catalog PR #50 adds that official slug to the remote source so startup and periodic catalog refreshes preserve it.First-party model facts
Sources
Verification
go test ./internal/registrygo test -run TestRegisterModelsForAuth_AntigravityFetchesWebSearchCapability ./sdk/cliproxygo build -o test-output ./cmd/server && rm test-outputRelated to #5421 (currently open).