fix(claude): handle max-token Responses truncation - #5438
Open
Reekin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_output_tokensand document model-scopedpayload.overrideconfiguration for budgets such as 128Kstop_reason: max_tokenstoresponse.incompletewithincomplete_details.reason: max_output_tokensProblem
Claude can consume the full output budget in reasoning without producing a visible assistant message. The Claude-to-Responses translator currently ignores
message_delta.delta.stop_reasonand always emitsresponse.completed, so Codex can silently finalize the turn with no final answer.Configuration
The override is applied after protocol translation and works for both OAuth and API-key Claude execution.
Verification
go test ./internal/translator/claude/openai/responses -count=1go test ./internal/runtime/executor -run TestClaudeExecutorPayloadOverrideMaxTokens -count=1go build -o <temp>/cli-proxy-api ./cmd/server/v1/responses-> configured Claude upstream receivedmax_tokens: 128000; downstream ended withresponse.incompleteand preserved reasoning outputgo test ./... -count=1was also exercised. Changed packages pass; the existing XAI TTFT timing assertion can intermittently reportttft = 0son Windows and passes independently.