Skip to content

Flow and CTC conversion fix #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

joris-gentinetta
Copy link
Contributor

  • In the track function, link() is called before add_flow(), such that the flow is never actually used.
  • In the to_ctc function, the forward_map returned by relabel_sequential is modified like this: 'fw[-1] = -1', because the parent_id -1 (no parent) should be mapped on itself. However, instead of adding a map from -1 to -1, this modifies the last value in the map and -1 is mapped to the default of 0. As the CTC format expects 0 for no parent, this is not an issue, but through the modification of the map, the parent of the last tracklet is set to -1, effectively cutting it off.

Copy link
Member

@JoOkuma JoOkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @joris-gentinetta, I appreciate the PR, and thanks for catching this.

We were mainly using the CLI for the CTC submission.

I left a minor comment, once you accept the change and tests pass I'll merge the PR.

Co-authored-by: Jordão Bragantini <[email protected]>
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@b2de376). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage        ?   82.86%           
=======================================
  Files           ?       91           
  Lines           ?     5597           
  Branches        ?        0           
=======================================
  Hits            ?     4638           
  Misses          ?      959           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoOkuma JoOkuma merged commit 27a51a7 into royerlab:main Feb 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants