fix custom onnxruntime version #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new variable so that built libraries appropriately reflect the custom onnxruntime version. Also added a symlink from libonxruntime.so.1
Owner
|
@fritz-fritz can you run |
Aligned file with defined formatting per `./build-aux/run-cmake-format --fail-error`
Contributor
Author
|
@royshil Should be good to go now ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new variable so that built libraries appropriately reflect the custom onnxruntime version.
Also added a symlink from libonxruntime.so.1
The real benefit of this is seen when leveraging CMakeUserPresets as shown in my gist here that addresses #591.
This pull request does not update the default onnxruntime versions or integrate with the installer scripts.