Cleaner ONNX Runtime downloader for Mac #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added find_package for onnxruntime in CMakeLists.txt to require ONNX Runtime during build. Updated DownloadOnnxRuntime.cmake to use versioned archive names and rename extracted directories for consistency across platforms.
Prepends ONNX Runtime to CMAKE_PREFIX_PATH and links onnxruntime::onnxruntime target. Ensures the ONNX Runtime include path is set correctly by modifying onnxruntimeTargets.cmake after download. Removes FetchOnnxruntime.cmake inclusion for non-system builds.
Moved ONNX Runtime find and path setup inside conditional to support USE_SYSTEM_ONNXRUNTIME. Added macOS-specific handling for ONNX Runtime dynamic library. Removed unused BUILD_TESTING variable from CMakePresets.json.
Collaborator
Author
|
@royshil Windows and Ubuntu are failing but they will be fixed later. |
royshil
approved these changes
Nov 5, 2025
Owner
royshil
left a comment
royshil
left a comment
There was a problem hiding this comment.
if you're OK with windows and ubuntu failig - GO!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Mac build
Don't care about Windows and Ubuntu now.