Fix Windows build with ONNX Runtime #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated CMakeLists.txt to improve ONNX Runtime linking for Apple and MSVC platforms, including explicit handling of shared libraries and provider dependencies. Commented out DML provider code in ort-session-utils.cpp for Windows, likely due to build or compatibility issues.
…royshil/obs-backgroundremoval into umireon/fix-windows-onnxruntime
Introduces src/Module.cpp to handle plugin load/unload events and custom DLL delay loading on Windows. Updates CMakeLists.txt to include the new source file and removes 'delayimp' from link libraries. Modifies plugin-main.c to call PluginLoaded and PluginUnloaded during module load/unload.
…royshil/obs-backgroundremoval into umireon/fix-windows-onnxruntime
Renamed src/Module.cpp to src/DelayLoad.cpp and updated CMakeLists.txt to reference the new filename. Removed PluginLoaded and PluginUnloaded calls from plugin-main.c to streamline plugin load/unload logic.
Adds installation of ONNX Runtime DLLs and PDBs to the Windows build in CMakeLists.txt. Refactors DelayLoad.cpp to resolve and load onnxruntime.dll from a specific plugin directory, improving reliability of DLL loading for the plugin.
…royshil/obs-backgroundremoval into umireon/fix-windows-onnxruntime
Reformatted DelayLoad.cpp for consistent indentation and style. Updated CMakeLists.txt to improve readability of the install() command by reformatting the file list.
Collaborator
Author
|
@royshil Managed to fix it on Windows. |
Deleted CMake scripts for ONNX Runtime integration and removed DirectML (DML) support from code, localization files, and documentation. This simplifies GPU provider options and cleans up unused Windows-specific code paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed Windows build and confirmed to work it stably.
DirectML support on ONNX Runtime is deprecated and having DirectML breaks our plugin so that DirectML support in our plugin is also removed.
Ubuntu build still broken and it will be fixed later.