Skip to content

Conversation

@umireon
Copy link
Collaborator

@umireon umireon commented Nov 9, 2025

(Automated bump changed the indentation)

General Summary

  • CI/Workflow Improvements:
    • Build, packaging, and artifact upload steps in GitHub Actions are now enabled (previously commented out).
    • Pages deployment workflow now builds with Astro, supports scheduled builds, and daily refreshes.
  • CMake Build Tweaks:
    • Simplified logic for ONNX Runtime GPU support and provider library handling.
    • Consistent use of ONNXRUNTIME_DIR and more robust shared object installation, especially on non-Windows platforms.
  • Documentation Updates:
    • Shields/Badges updated to reflect the current royshil/obs-backgroundremoval repo rather than forks.
    • Download instructions in README are simplified: directs users to central download/page links.
    • Support links moved to GitHub Discussions.
    • Old partner/related plugin references from locaal-ai removed.
    • Linux & build instructions pruned for brevity and centralized in web docs.
    • (The docs/UNINSTALL.md file was deleted.)
  • Website Overhaul (pages/):
    • Migrated from SvelteKit to Astro.
    • Large swathes of config and lock files changed or replaced.
      • E.g., .npmrc, .prettier*, README.md, eslint*, Svelte-related files deleted.
    • Package dependencies changed, reflecting the new Astro stack.
    • .gitignore and build outputs updated for Astro and Node conventions.

Notable Detailed Code/Config Diffs

  • .github/scripts/utils.zsh/setup_ubuntu:

    • libcurl4-openssl-dev dropped from the dependencies installed by script.
  • .github/workflows/build-project.yaml:

    • Steps to package, upload artifacts and debug symbols, and caching are now enabled (were previously commented out).
  • .github/workflows/pages.yaml:

    • Added a scheduled daily CI trigger.
    • Switched from npm run build (Svelte syntax) to npx astro build with explicit site and base parameters.
    • Artifact upload now references Astro's dist/ directory instead of SvelteKit's build/.
  • CMakeLists.txt:

    • DISABLE_ONNXRUNTIME_GPU always defined as a compile definition (used to be runtime-configurable).
    • Windows now uses ONNXRUNTIME_DIR instead of ONNXRUNTIME_ROOT, and all related variables updated.
    • Linux/Mac now install ONNX shared objects directly and adjust install RPATH.
  • README.md:

    • Shields/badges point to royshil/obs-backgroundremoval.
    • Download instructions centralized to a single link and removed lengthy OS-specific content (now on the web page/docs).
    • GitHub Discussions replaced Discord as recommended venue for support.
    • Uninstall instructions, and detailed build instructions removed.
  • docs/UNINSTALL.md: Deleted

  • pages/ website migration:

    • Old SvelteKit configuration and dependencies removed.
    • New Astro configuration (astro.config.mjs) added.
    • Package lock file rewritten for Astro ecosystem.

In summary:

  • Major Docs/site and CI improvements: The repo switched web generation from SvelteKit to Astro, many web build/config files replaced, and documentation was substantially trimmed and updated.
  • Improved build steps for CI and platform packaging.
  • Better clarity in install/build instructions for users and contributors.

If you want the raw diff or have questions about specific files or features, let me know!

@umireon umireon requested a review from royshil November 9, 2025 13:35
Copy link
Owner

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Changed the website field to point to the GitHub Pages site instead of the GitHub repository.
@umireon umireon merged commit bb6f023 into main Nov 9, 2025
8 checks passed
@umireon umireon deleted the releases/bump-1.3.1 branch November 10, 2025 23:28
sobalap pushed a commit to sobalap/obs-backgroundremoval that referenced this pull request Jan 7, 2026
* chore: bump version to 1.3.1 for release

* Update project website URL in buildspec.json

Changed the website field to point to the GitHub Pages site instead of the GitHub repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants