Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 14, 2025

The macOS download page was using the Ubuntu asset regex pattern, causing users to download Linux .deb files instead of macOS .pkg installers.

Changes

pages/src/pages/macos.astro

  • Changed asset regex from /x86_64-linux-gnu\.deb/ to /macos-universal\.pkg/
  • Updated error message to reflect macOS asset type
-const asset = release.assets.find((e) => /x86_64-linux-gnu\.deb/.test(e.name));
-if (!asset) throw new Error("Ubuntu asset not found!");
+const asset = release.assets.find((e) => /macos-universal\.pkg/.test(e.name));
+if (!asset) throw new Error("macOS asset not found!");

This aligns with the naming convention used in .github/workflows/build-project.yaml (line 218) where macOS artifacts are named ${pluginName}-${pluginVersion}-macos-universal.pkg.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/royshil/obs-REDACTEDremoval/releases/latest
    • Triggering command: curl -s REDACTED (http block)
    • Triggering command: node /home/REDACTED/work/obs-REDACTEDremoval/obs-REDACTEDremoval/pages/node_modules/.bin/astro build (http block)
  • telemetry.astro.build
    • Triggering command: node /home/REDACTED/work/obs-REDACTEDremoval/obs-REDACTEDremoval/pages/node_modules/.bin/astro build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Download link for MacOS is for (.deb file) instead of the macOS version</issue_title>
<issue_description>### Operating System

macOS 14

Other OS (if not listed above)

No response

Plugin Version

Latest version on the website

OBS Studio Version

31

OBS Studio Log URL

N/A

OBS Studio Crash Log URL (if applicable)

No response

Expected Behavior

Hey guys, the download link on the https://royshil.github.io/obs-backgroundremoval/macos/ page is a (.deb file) instead of the macOS version. That's why my Mac can't open it. i just wanted to raise it wit you in case you can take a look!

Actual Behavior

please see the Expected Behavior section

Steps to Reproduce

just go to https://royshil.github.io/obs-backgroundremoval/macos/ and click the download link
On my Mac what it installs is a .deb file

Additional Notes / Screenshots

No response

Confirmation

  • I have attached the required OBS log file(s).</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fix download link for macOS version instead of .deb file Fix macOS download page serving .deb instead of .pkg Nov 14, 2025
Copilot AI requested a review from umireon November 14, 2025 10:11
@umireon umireon marked this pull request as ready for review November 14, 2025 10:36
@umireon umireon requested a review from royshil November 14, 2025 10:36
Copy link
Owner

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@umireon umireon merged commit 1ce5693 into main Nov 14, 2025
14 of 18 checks passed
@umireon umireon deleted the copilot/fix-download-link-for-macos branch November 14, 2025 10:46
sobalap pushed a commit to sobalap/obs-backgroundremoval that referenced this pull request Jan 7, 2026
* Initial plan

* Fix macOS download link to use .pkg instead of .deb file

Co-authored-by: umireon <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: umireon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download link for MacOS is for (.deb file) instead of the macOS version

3 participants