Skip to content

Use system ICU and curl by default on Linux where possible #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tabby merged 3 commits into from
Oct 30, 2025
Merged

Use system ICU and curl by default on Linux where possible #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
748a1f4
Use system ICU and curl by default on Linux
Tabby Oct 29, 2025
82c3801
Add curl, icu, onnx and vulkan apt dependencies
Tabby Oct 29, 2025
6e97f54
Stick to using static ICU for CI builds for compatibility
Tabby Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/scripts/.Aptfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@ package 'cmake'
package 'ccache'
package 'git'
package 'jq'
package 'libcurl4-openssl-dev'
package 'libicu-dev'
package 'libopenblas-dev'
package 'libopenblas-openmp-dev'
package 'libsimde-dev'
package 'libvulkan-dev'
package 'ninja-build', bin: 'ninja'
package 'pkg-config'
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ set(USE_SYSTEM_ICU

if(USE_SYSTEM_ICU)
find_package(
ICU 75.1
ICU 70.1
COMPONENTS data uc i18n
REQUIRED)
target_link_libraries(${CMAKE_PROJECT_NAME} PRIVATE "${ICU_LIBRARIES}")
Expand Down
7 changes: 5 additions & 2 deletions CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@
"generator": "Ninja",
"warnings": {"dev": true, "deprecated": true},
"cacheVariables": {
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
"CMAKE_BUILD_TYPE": "RelWithDebInfo",
"USE_SYSTEM_CURL": true,
"USE_SYSTEM_ICU": true
}
},
{
Expand All @@ -94,7 +96,8 @@
"description": "Build for Linux x86_64 on CI",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "RelWithDebInfo",
"CMAKE_COMPILE_WARNING_AS_ERROR": true
"CMAKE_COMPILE_WARNING_AS_ERROR": true,
"USE_SYSTEM_ICU": false
}
},
{
Expand Down
Loading