Implement InputPin and OutputPin for Pin<I, DynFunction, P>#859
Draft
jannic wants to merge 3 commits intorp-rs:mainfrom
Draft
Implement InputPin and OutputPin for Pin<I, DynFunction, P>#859jannic wants to merge 3 commits intorp-rs:mainfrom
jannic wants to merge 3 commits intorp-rs:mainfrom
Conversation
Operations on this OutputPin are fallible: They return Err(DynPinError::IncompatibleFunction) if the pin is not configured as an output.
Member
Author
|
What other traits could sensibly be implemented for DynFunction? |
Member
|
I'd just add these for now and add more in another PR. When doing the #920 changes, this impl would have been useful! Without it, dyn pins aren't very useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operations on this are fallible: They return Err(DynPinError::IncompatibleFunction) if the pin is not configured to an incompatible function.