Draft
Conversation
Member
|
I changed the target branch of the PR. Some of the changes (namely to the latest rp2040-hal) have already been integrated there. |
99bd39f to
bb9d0db
Compare
Signed-off-by: Daniel Schaefer <dhs@frame.work>
bb9d0db to
430b884
Compare
Author
|
Thank you, fixed up :) |
Author
|
Tested build with: |
Member
|
I reviewed the current state of this crate and I have some doubts on what's the proper way to move forward with support for both embedded-hal 0.2.7 and 1.0-* On the implementation side:
In theory, we should aim at supporting any delay source (provided they implement the HAL). I also realized the CountDown support was broken, it should be as it is in: #27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a tough time with all these generic traits and structs. It compiles but I haven't tested it yet.
Must for merge wait until
embedded-hal1.0 is released andrp2040-halis also with support for that.