feat Return runtime error on stream error
#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kespinola
requested changes
Jul 31, 2025
Collaborator
kespinola
left a comment
kespinola
left a comment
There was a problem hiding this comment.
LG2M just comment about removing the trace or making it more generic depending on code internal.
crates/runtime/src/buffer.rs
Outdated
Comment on lines
44
to
46
| if e.code() == Code::Internal { | ||
| tracing::error!("Yellowstone server credentials error"); | ||
| } |
Collaborator
There was a problem hiding this comment.
Is code internal always credential errors? I'd just return the Error like you are and the caller can handle as they wish.
kespinola
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #101