Remove setters and getters from SourceTrait #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SourceTrait now defines its config type as part of the trait definition. Add DynSource which keeps consistent interface for starting a source. Refactor builder to take .source<SourceTrait>::().
kespinola
force-pushed
the
espi/vix-12-make-vixentoml-config-file-dynamically-contain-source-config
branch
from
e26c5e3 to
ccdd5fb
Compare
| let config = self | ||
| .sources_cfg | ||
| .get(&source.name()) | ||
| .expect("No source config"); |
Contributor
There was a problem hiding this comment.
Very likely way too nitpicky comment but I maybe mention the source name in the error would make it easier to find out which source is failing. Here before we had this:
"Source config not found for {source_name}. This should be set in your vixen \
toml config file in the `[source.{source_name}]` section."
fernandodeluret
approved these changes
Aug 9, 2025
fernandodeluret
merged commit 0c631bd
into
fernandod/vix-12-make-vixentoml-config-file-dynamically-contain-source-config
1 of 2 checks passed
kespinola
added a commit
that referenced
this pull request
Aug 19, 2025
* Make vixen.toml config file dynamically contain sources config * `feat` Expose fumarole prometheus metrics under crate feature flag * Remove setters and getters from SourceTrait (#116) The SourceTrait now defines its config type as part of the trait definition. Add DynSource which keeps consistent interface for starting a source. Refactor builder to take .source<SourceTrait>::(). * `chore` Bump fumarole client lib and fix lints * Fix import typo at README.md (#117) * Solana snapshot source * `chore` Fix lint issues and imports * `chore` Fix fmt lints * `fix` Update config to use default values and flatten for streams * `chore` Remove global filters * `feat` Make slot update field use a boolean flag * chore: Add back slotprefilter for consistent filter API --------- Co-authored-by: Fernando <[email protected]> Co-authored-by: riprsa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.source<SourceTrait>::()