Skip to content

Clean up variable trait #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2024
Merged

Clean up variable trait #24

merged 3 commits into from
Dec 16, 2024

Conversation

@contagon
Copy link
Collaborator

@contagon contagon commented Dec 16, 2024

This PR cleans up the variable trait a smidge. Specifically,

  • Datatype is now an associated type instead of a generic
  • VariableUmbrella -> VariableDtype
  • dual_convert has been renamed to cast with better trait bounds to make that work.
  • dual_setup has been renamed to dual_exp to better reflect what it does

@contagon contagon merged commit 7b7b3f1 into dev Dec 16, 2024
2 checks passed
@contagon contagon deleted the easton/variable-clean branch December 17, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@contagon