-
Notifications
You must be signed in to change notification settings - Fork 52
add tests for download --debugsource and --debuginfo options #1800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
pkratoch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests!
|
|
||
|
|
||
| Scenario: Download a debuginfo for an existing RPM | ||
| Given I use repository "dnf-ci-fedora-updates" as http | ||
| When I execute dnf with args "download --debuginfo libzstd" | ||
| Then the exit code is 0 | ||
| And stdout contains "libzstd-debuginfo-1.3.6-1.fc29.x86_64.rpm" | ||
| And stderr contains "libzstd-debuginfo-0:1.3.6-1.fc29" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that it's dependent on how the nevra is trimmed. Looking at how other download tests handled that, I noticed they don't check the stderr, only the actually downloaded packages, except for a few cases... But I am not sure how to do this best, so maybe let's keep it as it is.
| @xfail | ||
| Scenario: Download a debuginfo for an existing RPM with a different name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you look into why the debuginfo download doesn't work when the name is different? This should be either fixed in the existing PR, or an issue should be filed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was my mistake.. you can download
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? The test is now removed, but when I add it back, it fails.
67443a6 to
cdbae69
Compare
Add new test suite for the `--debugsource` and `--debuginfo` flags in dnf download command. This is a test for rpm-software-management/dnf5#2529 and rpm-software-management/dnf5#2547 Signed-off-by: Fellipe Henrique <[email protected]>
cdbae69 to
f2eced0
Compare
|
|
||
| @bz1637008 | ||
| @xfail | ||
| Scenario: Download debugsource for an RPM that doesn't exist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove all the debugsource tests from the download-debuginfo.feature, since they are now in the download-debugsource.feature?
Add new test suite for the
--debugsourceand--debuginfoflags in dnf download command.This is a test for rpm-software-management/dnf5#2529 and rpm-software-management/dnf5#2547