Skip to content

Conversation

@fhbash
Copy link
Contributor

@fhbash fhbash commented Dec 8, 2025

Add new test suite for the --debugsource and --debuginfo flags in dnf download command.

This is a test for rpm-software-management/dnf5#2529 and rpm-software-management/dnf5#2547

Copy link
Contributor

@pkratoch pkratoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!



Scenario: Download a debuginfo for an existing RPM
Given I use repository "dnf-ci-fedora-updates" as http
When I execute dnf with args "download --debuginfo libzstd"
Then the exit code is 0
And stdout contains "libzstd-debuginfo-1.3.6-1.fc29.x86_64.rpm"
And stderr contains "libzstd-debuginfo-0:1.3.6-1.fc29"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that it's dependent on how the nevra is trimmed. Looking at how other download tests handled that, I noticed they don't check the stderr, only the actually downloaded packages, except for a few cases... But I am not sure how to do this best, so maybe let's keep it as it is.

Comment on lines 28 to 29
@xfail
Scenario: Download a debuginfo for an existing RPM with a different name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you look into why the debuginfo download doesn't work when the name is different? This should be either fixed in the existing PR, or an issue should be filed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was my mistake.. you can download

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? The test is now removed, but when I add it back, it fails.

@fhbash fhbash force-pushed the download-debuginfo branch from 67443a6 to cdbae69 Compare December 15, 2025 13:18
@fhbash fhbash changed the title add tests for download --debugsource option add tests for download --debugsource and --debuginfo options Dec 15, 2025
@fhbash fhbash requested a review from pkratoch December 15, 2025 13:18
Add new test suite for the `--debugsource` and `--debuginfo` flags in dnf download command.

This is a test for rpm-software-management/dnf5#2529 and rpm-software-management/dnf5#2547

Signed-off-by: Fellipe Henrique <[email protected]>
@fhbash fhbash force-pushed the download-debuginfo branch from cdbae69 to f2eced0 Compare December 15, 2025 17:59

@bz1637008
@xfail
Scenario: Download debugsource for an RPM that doesn't exist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove all the debugsource tests from the download-debuginfo.feature, since they are now in the download-debugsource.feature?

@pkratoch pkratoch self-assigned this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants