Skip to content

Adapt behave tests for allow_vendor_change#1839

Merged
evan-goode merged 1 commit intorpm-software-management:mainfrom
fhbash:allow-vendor-change
Apr 29, 2026
Merged

Adapt behave tests for allow_vendor_change#1839
evan-goode merged 1 commit intorpm-software-management:mainfrom
fhbash:allow-vendor-change

Conversation

@fhbash
Copy link
Copy Markdown
Contributor

@fhbash fhbash commented Mar 3, 2026

Adapt behave tests for dnf5 allow_vendor_change=false default

fhbash added a commit to fhbash/dnf5 that referenced this pull request Mar 3, 2026
- Change the default value of `allow_vendor_change` from `true` to `false` so packages stick to
their original vendor during upgrades (rpm-software-management#712)
- When the solver blocks an update due to a vendor change restriction, print a hint suggesting
`--setopt=allow_vendor_change=true` (rpm-software-management#750)

A previous attempt to change this default was reverted because solver errors gave no indication
that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by
detecting `RULE_UPDATE` problems and telling the user how to override the restriction.

Closes: rpm-software-management#712 rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624

CI Tests: rpm-software-management/ci-dnf-stack#1839

Signed-off-by: Fellipe Henrique <me@fhbash.com>
fhbash added a commit to fhbash/dnf5 that referenced this pull request Mar 12, 2026
- Change the default value of `allow_vendor_change` from `true` to `false` so packages stick to
their original vendor during upgrades (rpm-software-management#712)
- When the solver blocks an update due to a vendor change restriction, print a hint suggesting
`--setopt=allow_vendor_change=true` (rpm-software-management#750)

A previous attempt to change this default was reverted because solver errors gave no indication
that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by
detecting `RULE_UPDATE` problems and telling the user how to override the restriction.

Closes: rpm-software-management#712 rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624

CI Tests: rpm-software-management/ci-dnf-stack#1839

Signed-off-by: Fellipe Henrique <me@fhbash.com>
fhbash added a commit to fhbash/dnf5 that referenced this pull request Apr 10, 2026
- Change the default value of `allow_vendor_change` from `true` to `false` so packages stick to
their original vendor during upgrades (rpm-software-management#712)
- When the solver blocks an update due to a vendor change restriction, print a hint suggesting
`--setopt=allow_vendor_change=true` (rpm-software-management#750)

A previous attempt to change this default was reverted because solver errors gave no indication
that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by
detecting `RULE_UPDATE` problems and telling the user how to override the restriction.

Closes: rpm-software-management#712 rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624

CI Tests: rpm-software-management/ci-dnf-stack#1839

Signed-off-by: Fellipe Henrique <me@fhbash.com>
fhbash added a commit to fhbash/dnf5 that referenced this pull request Apr 27, 2026
- When the solver blocks an update due to a vendor change restriction, print a hint suggesting
`--setopt=allow_vendor_change=true` (rpm-software-management#750)

A previous attempt to change this default was reverted because solver errors gave no indication
that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by
detecting `RULE_UPDATE` problems and telling the user how to override the restriction.

Closes: rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624

CI Tests: rpm-software-management/ci-dnf-stack#1839

Signed-off-by: Fellipe Henrique <me@fhbash.com>
fhbash added a commit to fhbash/dnf5 that referenced this pull request Apr 27, 2026
- When the solver blocks an update due to a vendor change restriction, print a hint suggesting
`--setopt=allow_vendor_change=true` (rpm-software-management#750)

A previous attempt to change this default was reverted because solver errors gave no indication
that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by
detecting `RULE_UPDATE` problems and telling the user how to override the restriction.

Closes: rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624

CI Tests: rpm-software-management/ci-dnf-stack#1839

Signed-off-by: Fellipe Henrique <me@fhbash.com>
Copy link
Copy Markdown
Member

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we haven't changed the default just yet, these tests need to be adapted to test both false and true cases properly

@fhbash fhbash force-pushed the allow-vendor-change branch from 7c536ab to 48a4a73 Compare April 28, 2026 18:42
@fhbash fhbash requested a review from m-blaha April 28, 2026 18:43
@fhbash
Copy link
Copy Markdown
Contributor Author

fhbash commented Apr 28, 2026

/packit test rpm-software-management/dnf5#2641

Copy link
Copy Markdown
Member

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evan-goode evan-goode merged commit ad77b50 into rpm-software-management:main Apr 29, 2026
10 of 13 checks passed
Userfrom1995 pushed a commit to Userfrom1995/dnf5 that referenced this pull request Apr 30, 2026
- When the solver blocks an update due to a vendor change restriction, print a hint suggesting
`--setopt=allow_vendor_change=true` (rpm-software-management#750)

A previous attempt to change this default was reverted because solver errors gave no indication
that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by
detecting `RULE_UPDATE` problems and telling the user how to override the restriction.

Closes: rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624

CI Tests: rpm-software-management/ci-dnf-stack#1839

Signed-off-by: Fellipe Henrique <me@fhbash.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants