Adapt behave tests for allow_vendor_change#1839
Merged
evan-goode merged 1 commit intorpm-software-management:mainfrom Apr 29, 2026
Merged
Adapt behave tests for allow_vendor_change#1839evan-goode merged 1 commit intorpm-software-management:mainfrom
evan-goode merged 1 commit intorpm-software-management:mainfrom
Conversation
fhbash
added a commit
to fhbash/dnf5
that referenced
this pull request
Mar 3, 2026
- Change the default value of `allow_vendor_change` from `true` to `false` so packages stick to their original vendor during upgrades (rpm-software-management#712) - When the solver blocks an update due to a vendor change restriction, print a hint suggesting `--setopt=allow_vendor_change=true` (rpm-software-management#750) A previous attempt to change this default was reverted because solver errors gave no indication that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by detecting `RULE_UPDATE` problems and telling the user how to override the restriction. Closes: rpm-software-management#712 rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624 CI Tests: rpm-software-management/ci-dnf-stack#1839 Signed-off-by: Fellipe Henrique <me@fhbash.com>
fhbash
added a commit
to fhbash/dnf5
that referenced
this pull request
Mar 12, 2026
- Change the default value of `allow_vendor_change` from `true` to `false` so packages stick to their original vendor during upgrades (rpm-software-management#712) - When the solver blocks an update due to a vendor change restriction, print a hint suggesting `--setopt=allow_vendor_change=true` (rpm-software-management#750) A previous attempt to change this default was reverted because solver errors gave no indication that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by detecting `RULE_UPDATE` problems and telling the user how to override the restriction. Closes: rpm-software-management#712 rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624 CI Tests: rpm-software-management/ci-dnf-stack#1839 Signed-off-by: Fellipe Henrique <me@fhbash.com>
fhbash
added a commit
to fhbash/dnf5
that referenced
this pull request
Apr 10, 2026
- Change the default value of `allow_vendor_change` from `true` to `false` so packages stick to their original vendor during upgrades (rpm-software-management#712) - When the solver blocks an update due to a vendor change restriction, print a hint suggesting `--setopt=allow_vendor_change=true` (rpm-software-management#750) A previous attempt to change this default was reverted because solver errors gave no indication that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by detecting `RULE_UPDATE` problems and telling the user how to override the restriction. Closes: rpm-software-management#712 rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624 CI Tests: rpm-software-management/ci-dnf-stack#1839 Signed-off-by: Fellipe Henrique <me@fhbash.com>
fhbash
added a commit
to fhbash/dnf5
that referenced
this pull request
Apr 27, 2026
- When the solver blocks an update due to a vendor change restriction, print a hint suggesting `--setopt=allow_vendor_change=true` (rpm-software-management#750) A previous attempt to change this default was reverted because solver errors gave no indication that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by detecting `RULE_UPDATE` problems and telling the user how to override the restriction. Closes: rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624 CI Tests: rpm-software-management/ci-dnf-stack#1839 Signed-off-by: Fellipe Henrique <me@fhbash.com>
fhbash
added a commit
to fhbash/dnf5
that referenced
this pull request
Apr 27, 2026
- When the solver blocks an update due to a vendor change restriction, print a hint suggesting `--setopt=allow_vendor_change=true` (rpm-software-management#750) A previous attempt to change this default was reverted because solver errors gave no indication that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by detecting `RULE_UPDATE` problems and telling the user how to override the restriction. Closes: rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624 CI Tests: rpm-software-management/ci-dnf-stack#1839 Signed-off-by: Fellipe Henrique <me@fhbash.com>
Conan-Kudo
approved these changes
Apr 28, 2026
Member
Conan-Kudo
left a comment
There was a problem hiding this comment.
Since we haven't changed the default just yet, these tests need to be adapted to test both false and true cases properly
7c536ab to
48a4a73
Compare
Contributor
Author
|
/packit test rpm-software-management/dnf5#2641 |
ad77b50
into
rpm-software-management:main
10 of 13 checks passed
Userfrom1995
pushed a commit
to Userfrom1995/dnf5
that referenced
this pull request
Apr 30, 2026
- When the solver blocks an update due to a vendor change restriction, print a hint suggesting `--setopt=allow_vendor_change=true` (rpm-software-management#750) A previous attempt to change this default was reverted because solver errors gave no indication that vendor locking was the cause. The new hint in `print_resolve_hints()` addresses that by detecting `RULE_UPDATE` problems and telling the user how to override the restriction. Closes: rpm-software-management#750 SWMBZBUGSM-153 BZ#2219624 CI Tests: rpm-software-management/ci-dnf-stack#1839 Signed-off-by: Fellipe Henrique <me@fhbash.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt behave tests for dnf5
allow_vendor_change=falsedefault