Skip to content

Allow the local plugin to exclude packages from the local cache repo#473

Open
wheelerlaw wants to merge 1 commit intorpm-software-management:masterfrom
wheelerlaw:local-plugin-exclude-packages
Open

Allow the local plugin to exclude packages from the local cache repo#473
wheelerlaw wants to merge 1 commit intorpm-software-management:masterfrom
wheelerlaw:local-plugin-exclude-packages

Conversation

@wheelerlaw
Copy link
Copy Markdown

When using the local plugin as a cache for multiple guest machines, packages that might get installed in the guest that are ignored on the host will end up bypassing the exclude filters in the repo configs on the host.

This change allows the exclude option to be configured in the local plugin so that these packages will still be excluded from installation.

@pkratoch pkratoch self-assigned this Dec 12, 2022
Comment thread plugins/local.py
else:
raise KeyError("Disabled")

main["exclude"] = self.get_value("main", "exclude", "")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the main configuration, we use the option "excludepks", it is documented as such and the alias "exclude" is there just for compatibility with yum. So, I would propose to either rename this as "excludepkgs", or to support both variants.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the exclude field a true alias of excludepkgs? Or are they two separate fields that need to be read independently?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkratoch
Copy link
Copy Markdown
Contributor

It would also be nice to add a note about this option to the documentation ( https://github.com/rpm-software-management/dnf-plugins-core/blob/master/doc/local.rst ) even though the documentation of this plugin's config options is in a bad shape already.

@wheelerlaw
Copy link
Copy Markdown
Author

It would also be nice to add a note about this option to the documentation ( https://github.com/rpm-software-management/dnf-plugins-core/blob/master/doc/local.rst ) even though the documentation of this plugin's config options is in a bad shape already.

I will do some updating to the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants