Skip to content

Mirror the changes made to createrepo_c#146

Merged
kontura merged 1 commit intorpm-software-management:masterfrom
dralley:master
Apr 28, 2026
Merged

Mirror the changes made to createrepo_c#146
kontura merged 1 commit intorpm-software-management:masterfrom
dralley:master

Conversation

@dralley
Copy link
Copy Markdown
Contributor

@dralley dralley commented Mar 21, 2026

Update python build infra to scikit-build-core, use a shared VERSION file, update dist-info creation

@dralley dralley marked this pull request as ready for review March 21, 2026 04:21
@kontura
Copy link
Copy Markdown
Contributor

kontura commented Apr 1, 2026

@dralley Thank you!
Could you rebase?

Also the Python CI builds have failed but I haven't investigated whether it is related yet.

@dralley
Copy link
Copy Markdown
Contributor Author

dralley commented Apr 19, 2026

I rebased. I don't think the CI builds would be related, firstly because it's not merged yet, but also it looks like a C compiler warning-treated-as-error type of thing.


  In file included from /opt/_internal/cpython-3.9.25/include/python3.9/Python.h:81,
                   from /project/libcomps/src/python/src/pycomps_macros.h:24,
                   from /project/libcomps/src/python/src/pycomps.c:28:
  /opt/_internal/cpython-3.9.25/include/python3.9/pytime.h:153:60: warning: ‘struct timespec’ declared inside parameter list will not be visible outside of this definition or declaration
    153 | PyAPI_FUNC(int) _PyTime_FromTimespec(_PyTime_t *tp, struct timespec *ts);
        |                                                            ^~~~~~~~
  /opt/_internal/cpython-3.9.25/include/python3.9/pytime.h:158:56: warning: ‘struct timespec’ declared inside parameter list will not be visible outside of this definition or declaration
    158 | PyAPI_FUNC(int) _PyTime_AsTimespec(_PyTime_t t, struct timespec *ts);
        |                                                        ^~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:775:22: error: implicit declaration of function ‘_PyCFunction_CAST’; did you mean ‘PyCFunction_Call’? [-Wimplicit-function-declaration]
    775 |     {"groups_match", _PyCFunction_CAST(PyCOMPS_groups_match), METH_VARARGS | METH_KEYWORDS,
        |                      ^~~~~~~~~~~~~~~~~
        |                      PyCFunction_Call
  /project/libcomps/src/python/src/pycomps.c:775:22: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  /project/libcomps/src/python/src/pycomps.c:775:22: note: (near initialization for ‘PyCOMPS_methods[0].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:775:22: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:775:22: note: (near initialization for ‘PyCOMPS_methods[0].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:777:26: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    777 |     {"categories_match", _PyCFunction_CAST(PyCOMPS_categories_match), METH_VARARGS | METH_KEYWORDS,
        |                          ^~~~~~~~~~~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:777:26: note: (near initialization for ‘PyCOMPS_methods[1].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:777:26: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:777:26: note: (near initialization for ‘PyCOMPS_methods[1].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:779:28: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    779 |     {"environments_match", _PyCFunction_CAST(PyCOMPS_envs_match), METH_VARARGS | METH_KEYWORDS,
        |                            ^~~~~~~~~~~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:779:28: note: (near initialization for ‘PyCOMPS_methods[2].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:779:28: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:779:28: note: (near initialization for ‘PyCOMPS_methods[2].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:781:18: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    781 |     {"validate", _PyCFunction_CAST(PyCOMPS_validate), METH_NOARGS,
        |                  ^~~~~~~~~~~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:781:18: note: (near initialization for ‘PyCOMPS_methods[3].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:781:18: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:781:18: note: (near initialization for ‘PyCOMPS_methods[3].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:783:21: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    783 |     {"validate_nf", _PyCFunction_CAST(PyCOMPS_validate_nf), METH_NOARGS,
        |                     ^~~~~~~~~~~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:783:21: note: (near initialization for ‘PyCOMPS_methods[4].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:783:21: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:783:21: note: (near initialization for ‘PyCOMPS_methods[4].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:785:15: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    785 |     {"xml_f", _PyCFunction_CAST(PyCOMPS_toxml_f), METH_VARARGS | METH_KEYWORDS,
        |               ^~~~~~~~~~~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:785:15: note: (near initialization for ‘PyCOMPS_methods[5].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:785:15: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:785:15: note: (near initialization for ‘PyCOMPS_methods[5].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:787:17: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    787 |     {"xml_str", _PyCFunction_CAST(PyCOMPS_toxml_str), METH_VARARGS | METH_KEYWORDS,
        |                 ^~~~~~~~~~~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:787:17: note: (near initialization for ‘PyCOMPS_methods[6].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:787:17: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:787:17: note: (near initialization for ‘PyCOMPS_methods[6].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:789:17: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    789 |     {"toxml_f", _PyCFunction_CAST(PyCOMPS_toxml_f), METH_VARARGS | METH_KEYWORDS,
        |                 ^~~~~~~~~~~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:789:17: note: (near initialization for ‘PyCOMPS_methods[7].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:789:17: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:789:17: note: (near initialization for ‘PyCOMPS_methods[7].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:791:19: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    791 |     {"toxml_str", _PyCFunction_CAST(PyCOMPS_toxml_str), METH_VARARGS | METH_KEYWORDS,
        |                   ^~~~~~~~~~~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:791:19: note: (near initialization for ‘PyCOMPS_methods[8].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:791:19: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:791:19: note: (near initialization for ‘PyCOMPS_methods[8].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:793:19: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    793 |     {"fromxml_f", _PyCFunction_CAST(PyCOMPS_fromxml_f), METH_VARARGS | METH_KEYWORDS,
        |                   ^~~~~~~~~~~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:793:19: note: (near initialization for ‘PyCOMPS_methods[9].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:793:19: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:793:19: note: (near initialization for ‘PyCOMPS_methods[9].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:795:21: error: initialization of ‘PyObject * (*)(PyObject *, PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *)’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    795 |     {"fromxml_str", _PyCFunction_CAST(PyCOMPS_fromxml_str), METH_VARARGS | METH_KEYWORDS,
        |                     ^~~~~~~~~~~~~~~~~
  /project/libcomps/src/python/src/pycomps.c:795:21: note: (near initialization for ‘PyCOMPS_methods[10].ml_meth’)
  /project/libcomps/src/python/src/pycomps.c:795:21: error: initializer element is not constant
  /project/libcomps/src/python/src/pycomps.c:795:21: note: (near initialization for ‘PyCOMPS_methods[10].ml_meth’)

Comment thread libcomps/src/python/docs/doc-sources/conf.py Outdated
@dralley dralley force-pushed the master branch 2 times, most recently from c5bd3be to 8bd6cb2 Compare April 20, 2026 14:38
Comment thread libcomps/src/python/src/CMakeLists.txt
Update python build infra to scikit-build-core, use a shared VERSION
file, update dist-info creation
@kontura kontura merged commit 4ed8a0d into rpm-software-management:master Apr 28, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants